Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](nereids)support alter table command #44058

Merged
merged 15 commits into from
Dec 27, 2024

Conversation

starocean999
Copy link
Contributor

support alter table command in nereids

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

2 similar comments
@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

4 similar comments
@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

1 similar comment
@starocean999
Copy link
Contributor Author

run buildall

Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In gensrc/script/gen_build_version.sh line 38:
if [[ ${build_version_hotfix} > 0 ]]; then
                              ^-- SC2071 (error): > is for string comparisons. Use -gt instead.


In gensrc/script/gen_build_version.sh line 228:
if [[ ${build_version_hotfix} > 0 ]]; then
                              ^-- SC2071 (error): > is for string comparisons. Use -gt instead.

For more information:
  https://www.shellcheck.net/wiki/SC2071 -- > is for string comparisons. Use ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

@starocean999
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39997 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d22014b923b2b7d1873415293fe244ff207e2a32, data reload: false

------ Round 1 ----------------------------------
q1	11742	7484	7308	7308
q2	451	198	189	189
q3	1474	1169	1201	1169
q4	3460	807	813	807
q5	2856	2733	2690	2690
q6	239	150	153	150
q7	991	627	619	619
q8	2386	1837	1929	1837
q9	6446	6443	6384	6384
q10	3398	2338	2327	2327
q11	396	265	263	263
q12	412	234	226	226
q13	16996	2919	2987	2919
q14	262	220	207	207
q15	565	494	489	489
q16	649	593	582	582
q17	986	538	564	538
q18	7469	6678	6737	6678
q19	1342	950	1047	950
q20	446	188	189	188
q21	4108	3148	3372	3148
q22	383	329	329	329
Total cold run time: 67457 ms
Total hot run time: 39997 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7245	7261	7265	7261
q2	340	230	234	230
q3	2935	2759	2766	2759
q4	2025	1790	1702	1702
q5	5378	5352	5408	5352
q6	220	139	140	139
q7	2106	1697	1709	1697
q8	3258	3400	3428	3400
q9	8538	8520	8628	8520
q10	3521	3410	3408	3408
q11	587	495	497	495
q12	786	569	565	565
q13	7272	3000	2958	2958
q14	291	267	274	267
q15	559	499	490	490
q16	704	629	644	629
q17	1790	1589	1601	1589
q18	7778	7496	7338	7338
q19	1683	1468	1513	1468
q20	2062	1810	1795	1795
q21	5319	5207	5211	5207
q22	668	600	586	586
Total cold run time: 65065 ms
Total hot run time: 57855 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190440 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d22014b923b2b7d1873415293fe244ff207e2a32, data reload: false

query1	972	370	373	370
query2	6513	2541	2454	2454
query3	6711	209	222	209
query4	34012	23341	23402	23341
query5	4299	471	489	471
query6	285	204	195	195
query7	4622	309	313	309
query8	309	245	250	245
query9	9697	2758	2749	2749
query10	497	253	257	253
query11	18058	15149	15086	15086
query12	160	108	105	105
query13	1665	427	439	427
query14	11540	7624	7381	7381
query15	318	182	184	182
query16	8192	445	450	445
query17	1793	589	574	574
query18	2145	306	331	306
query19	374	149	150	149
query20	116	119	108	108
query21	206	110	100	100
query22	4435	4297	4219	4219
query23	34838	33532	33697	33532
query24	10317	2392	2412	2392
query25	644	381	383	381
query26	1355	150	158	150
query27	2872	345	329	329
query28	7770	2458	2433	2433
query29	861	415	402	402
query30	291	151	155	151
query31	1110	782	810	782
query32	95	56	58	56
query33	787	284	295	284
query34	996	506	511	506
query35	895	772	730	730
query36	1089	946	962	946
query37	140	79	75	75
query38	4196	4018	4263	4018
query39	1476	1454	1420	1420
query40	282	104	125	104
query41	46	50	47	47
query42	114	101	99	99
query43	537	518	500	500
query44	1270	800	800	800
query45	191	165	166	165
query46	1159	724	710	710
query47	1941	1833	1858	1833
query48	437	326	322	322
query49	1158	396	400	396
query50	804	379	377	377
query51	7170	7191	7002	7002
query52	99	93	90	90
query53	256	185	188	185
query54	1180	401	418	401
query55	83	78	77	77
query56	266	234	235	234
query57	1215	1110	1088	1088
query58	239	214	219	214
query59	3315	3067	3271	3067
query60	287	246	286	246
query61	111	104	111	104
query62	892	669	684	669
query63	217	193	188	188
query64	4168	677	636	636
query65	3284	3187	3240	3187
query66	911	314	311	311
query67	15675	15397	15420	15397
query68	5287	565	549	549
query69	461	251	260	251
query70	1196	1094	1112	1094
query71	437	250	255	250
query72	6447	4097	4050	4050
query73	785	356	361	356
query74	10465	8954	8880	8880
query75	3668	2637	2700	2637
query76	3411	1085	1030	1030
query77	551	273	282	273
query78	10339	9446	9324	9324
query79	2491	611	636	611
query80	1156	432	482	432
query81	534	236	226	226
query82	719	119	118	118
query83	243	154	155	154
query84	234	68	80	68
query85	1540	304	301	301
query86	482	306	300	300
query87	4753	4403	4455	4403
query88	4138	2260	2215	2215
query89	424	311	299	299
query90	2139	190	188	188
query91	138	104	107	104
query92	66	56	54	54
query93	1644	572	563	563
query94	955	283	291	283
query95	355	244	254	244
query96	615	274	285	274
query97	2820	2706	2675	2675
query98	222	195	200	195
query99	1572	1328	1325	1325
Total cold run time: 304245 ms
Total hot run time: 190440 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.87 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d22014b923b2b7d1873415293fe244ff207e2a32, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.44	0.40	0.39
query6	1.20	0.66	0.65
query7	0.03	0.02	0.01
query8	0.04	0.03	0.04
query9	0.57	0.52	0.51
query10	0.55	0.60	0.55
query11	0.14	0.09	0.10
query12	0.14	0.11	0.12
query13	0.61	0.62	0.60
query14	2.85	2.75	2.72
query15	0.89	0.83	0.82
query16	0.39	0.38	0.37
query17	1.05	1.05	1.06
query18	0.23	0.22	0.20
query19	1.82	1.80	1.97
query20	0.02	0.01	0.01
query21	15.36	0.58	0.59
query22	2.85	2.64	2.06
query23	17.04	0.84	0.94
query24	2.60	0.90	2.07
query25	0.41	0.19	0.06
query26	0.45	0.14	0.14
query27	0.05	0.05	0.04
query28	10.26	1.11	1.07
query29	12.58	3.25	3.24
query30	0.25	0.06	0.06
query31	2.84	0.40	0.37
query32	3.27	0.48	0.47
query33	3.07	3.12	3.25
query34	17.00	4.47	4.48
query35	4.52	4.53	4.56
query36	0.69	0.48	0.47
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.13
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.67 s
Total hot run time: 32.87 s

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40180 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e7230a1602ac8219c13335287a8443e734890061, data reload: false

------ Round 1 ----------------------------------
q1	17637	7393	7238	7238
q2	2045	179	176	176
q3	10584	1094	1162	1094
q4	10495	760	705	705
q5	7623	2729	2710	2710
q6	239	152	147	147
q7	992	640	611	611
q8	9247	1858	1906	1858
q9	6636	6523	6512	6512
q10	7030	2352	2318	2318
q11	466	269	263	263
q12	442	227	228	227
q13	18000	2991	3082	2991
q14	242	215	216	215
q15	564	505	508	505
q16	675	603	605	603
q17	990	577	604	577
q18	7166	6667	6749	6667
q19	1346	973	1018	973
q20	480	190	195	190
q21	4024	3344	3279	3279
q22	377	324	321	321
Total cold run time: 107300 ms
Total hot run time: 40180 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7306	7379	7244	7244
q2	335	240	243	240
q3	3093	3022	3164	3022
q4	2096	1868	1877	1868
q5	5793	5827	5843	5827
q6	234	148	143	143
q7	2295	1928	1801	1801
q8	3385	3524	3528	3524
q9	9011	8987	9007	8987
q10	3574	3533	3506	3506
q11	611	508	521	508
q12	814	602	608	602
q13	16545	3167	3063	3063
q14	324	281	276	276
q15	553	512	496	496
q16	664	664	651	651
q17	1869	1637	1616	1616
q18	8345	7825	7715	7715
q19	1733	1503	1627	1503
q20	2089	1858	1886	1858
q21	5720	5609	5404	5404
q22	651	585	575	575
Total cold run time: 77040 ms
Total hot run time: 60429 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196776 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e7230a1602ac8219c13335287a8443e734890061, data reload: false

query1	1289	930	909	909
query2	6214	2372	2254	2254
query3	11049	4681	4749	4681
query4	32924	23285	23398	23285
query5	4073	473	458	458
query6	279	191	186	186
query7	3988	320	318	318
query8	296	251	241	241
query9	9242	2773	2778	2773
query10	469	268	246	246
query11	17771	15290	15222	15222
query12	167	104	104	104
query13	1570	465	438	438
query14	13112	7070	7448	7070
query15	261	192	190	190
query16	7981	509	501	501
query17	1625	610	582	582
query18	1425	310	329	310
query19	386	171	171	171
query20	133	113	112	112
query21	204	108	108	108
query22	4653	4422	4392	4392
query23	35932	33720	33636	33636
query24	8131	2485	2675	2485
query25	559	385	418	385
query26	704	157	155	155
query27	2068	335	358	335
query28	6478	2505	2468	2468
query29	678	427	458	427
query30	238	155	152	152
query31	1022	836	835	835
query32	105	63	58	58
query33	603	294	305	294
query34	953	546	540	540
query35	855	760	794	760
query36	1086	1000	964	964
query37	122	86	75	75
query38	4195	4174	4219	4174
query39	1505	1460	1489	1460
query40	216	108	103	103
query41	45	43	45	43
query42	121	107	109	107
query43	551	503	497	497
query44	1212	833	842	833
query45	203	181	166	166
query46	1203	754	725	725
query47	2038	1885	1945	1885
query48	419	321	324	321
query49	876	411	384	384
query50	865	387	388	387
query51	7344	7281	7188	7188
query52	105	98	91	91
query53	262	194	186	186
query54	854	415	433	415
query55	87	78	82	78
query56	270	252	252	252
query57	1274	1153	1154	1153
query58	234	215	231	215
query59	3497	3132	3208	3132
query60	284	250	267	250
query61	112	109	106	106
query62	861	687	687	687
query63	224	197	192	192
query64	3775	708	694	694
query65	3338	3267	3267	3267
query66	734	313	297	297
query67	16613	15657	15535	15535
query68	5964	565	563	563
query69	480	256	266	256
query70	1101	1141	1130	1130
query71	515	258	259	258
query72	6384	4224	4099	4099
query73	803	369	369	369
query74	10059	8810	8802	8802
query75	3610	2630	2674	2630
query76	4337	1118	1220	1118
query77	697	279	278	278
query78	10326	9364	9426	9364
query79	1123	603	594	594
query80	1035	516	434	434
query81	517	244	231	231
query82	407	120	123	120
query83	193	147	143	143
query84	288	74	72	72
query85	925	307	310	307
query86	353	301	312	301
query87	4538	4561	4367	4367
query88	3281	2254	2226	2226
query89	422	300	301	300
query90	1977	193	190	190
query91	138	106	107	106
query92	67	51	56	51
query93	1827	566	550	550
query94	690	331	284	284
query95	347	251	255	251
query96	633	276	278	276
query97	2878	2670	2706	2670
query98	221	198	198	198
query99	1564	1317	1295	1295
Total cold run time: 299662 ms
Total hot run time: 196776 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.38 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e7230a1602ac8219c13335287a8443e734890061, data reload: false

query1	0.04	0.03	0.03
query2	0.10	0.03	0.03
query3	0.23	0.08	0.07
query4	1.61	0.10	0.11
query5	0.42	0.42	0.39
query6	1.15	0.66	0.69
query7	0.03	0.01	0.02
query8	0.04	0.04	0.03
query9	0.60	0.51	0.50
query10	0.55	0.58	0.55
query11	0.15	0.10	0.10
query12	0.13	0.11	0.11
query13	0.60	0.61	0.60
query14	2.74	2.74	2.79
query15	0.89	0.83	0.82
query16	0.39	0.38	0.39
query17	1.00	0.98	1.05
query18	0.23	0.23	0.21
query19	1.89	1.86	2.05
query20	0.01	0.01	0.01
query21	15.36	0.60	0.59
query22	2.88	2.80	1.67
query23	16.89	1.09	0.83
query24	3.41	1.90	0.66
query25	0.33	0.19	0.10
query26	0.40	0.14	0.14
query27	0.05	0.05	0.04
query28	10.15	1.09	1.08
query29	12.60	3.29	3.27
query30	0.25	0.07	0.07
query31	2.88	0.38	0.38
query32	3.24	0.45	0.47
query33	3.04	3.14	3.12
query34	17.10	4.51	4.55
query35	4.52	4.56	4.51
query36	0.66	0.48	0.47
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 107.04 s
Total hot run time: 32.38 s

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39864 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e7230a1602ac8219c13335287a8443e734890061, data reload: false

------ Round 1 ----------------------------------
q1	17566	7410	7266	7266
q2	2054	185	168	168
q3	10620	1094	1123	1094
q4	10487	749	745	745
q5	7623	2693	2717	2693
q6	240	157	151	151
q7	995	630	606	606
q8	9272	1873	1932	1873
q9	6577	6360	6408	6360
q10	7372	2361	2384	2361
q11	462	272	274	272
q12	418	236	229	229
q13	17766	2881	2943	2881
q14	250	228	216	216
q15	554	509	506	506
q16	658	579	605	579
q17	981	515	608	515
q18	7157	6672	6658	6658
q19	1381	956	1001	956
q20	447	191	185	185
q21	4022	3240	3283	3240
q22	383	314	310	310
Total cold run time: 107285 ms
Total hot run time: 39864 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7290	7250	7277	7250
q2	328	233	227	227
q3	2909	2803	2947	2803
q4	2054	1787	1852	1787
q5	5671	5650	5648	5648
q6	225	145	144	144
q7	2261	1774	1869	1774
q8	3390	3542	3527	3527
q9	8836	8915	8925	8915
q10	3623	3558	3576	3558
q11	604	519	519	519
q12	810	616	589	589
q13	12538	3062	3095	3062
q14	304	274	284	274
q15	563	522	499	499
q16	674	626	644	626
q17	1864	1618	1600	1600
q18	8294	7814	7669	7669
q19	1720	1576	1583	1576
q20	2089	1916	1853	1853
q21	5514	5356	5485	5356
q22	663	605	578	578
Total cold run time: 72224 ms
Total hot run time: 59834 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197699 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e7230a1602ac8219c13335287a8443e734890061, data reload: false

query1	1285	982	918	918
query2	6250	2420	2375	2375
query3	10961	4734	4728	4728
query4	33307	23342	23970	23342
query5	4593	485	497	485
query6	300	194	192	192
query7	3991	309	327	309
query8	310	251	263	251
query9	9484	2798	2770	2770
query10	478	269	252	252
query11	18122	15314	15290	15290
query12	162	108	111	108
query13	1608	431	429	429
query14	9979	7193	7047	7047
query15	324	184	188	184
query16	7584	436	440	436
query17	1630	588	586	586
query18	1674	315	311	311
query19	360	172	163	163
query20	131	116	111	111
query21	204	109	109	109
query22	4700	4460	4431	4431
query23	34514	33726	33846	33726
query24	11203	2522	2588	2522
query25	654	390	395	390
query26	1318	156	163	156
query27	2820	340	339	339
query28	7454	2476	2509	2476
query29	887	437	423	423
query30	240	154	149	149
query31	1037	847	880	847
query32	95	60	59	59
query33	756	316	294	294
query34	1057	543	552	543
query35	948	792	771	771
query36	1102	946	972	946
query37	155	78	77	77
query38	4164	4302	4282	4282
query39	1564	1493	1462	1462
query40	208	105	104	104
query41	47	43	45	43
query42	121	108	106	106
query43	558	510	508	508
query44	1307	832	839	832
query45	183	162	165	162
query46	1207	762	747	747
query47	2036	1918	1943	1918
query48	414	324	322	322
query49	1036	412	405	405
query50	835	434	406	406
query51	7345	7229	7241	7229
query52	106	96	92	92
query53	264	187	197	187
query54	910	432	429	429
query55	84	84	84	84
query56	272	255	246	246
query57	1311	1173	1179	1173
query58	271	231	223	223
query59	3481	3197	3139	3139
query60	284	263	248	248
query61	120	104	108	104
query62	926	767	740	740
query63	236	196	207	196
query64	3996	740	677	677
query65	3328	3295	3268	3268
query66	763	303	311	303
query67	16304	15473	15547	15473
query68	5807	558	567	558
query69	474	261	263	261
query70	1145	1137	1081	1081
query71	489	258	266	258
query72	6564	4079	4147	4079
query73	796	371	383	371
query74	10432	8858	8785	8785
query75	3689	2690	2655	2655
query76	3738	1250	1111	1111
query77	636	312	277	277
query78	10244	9446	9411	9411
query79	1263	601	615	601
query80	970	463	439	439
query81	522	250	225	225
query82	504	124	124	124
query83	196	151	148	148
query84	293	76	72	72
query85	1367	319	325	319
query86	416	305	306	305
query87	4644	4460	4468	4460
query88	4023	2233	2194	2194
query89	424	292	302	292
query90	2109	190	191	190
query91	136	104	117	104
query92	63	50	53	50
query93	2385	557	545	545
query94	851	290	276	276
query95	368	256	253	253
query96	622	281	276	276
query97	2911	2736	2691	2691
query98	213	202	192	192
query99	1755	1455	1443	1443
Total cold run time: 305407 ms
Total hot run time: 197699 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.65 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e7230a1602ac8219c13335287a8443e734890061, data reload: false

query1	0.03	0.04	0.05
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.11
query5	0.42	0.41	0.42
query6	1.14	0.67	0.65
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.58	0.51	0.50
query10	0.55	0.55	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.10
query13	0.62	0.62	0.60
query14	2.85	2.83	2.79
query15	0.87	0.84	0.82
query16	0.37	0.38	0.39
query17	1.06	1.06	1.08
query18	0.22	0.21	0.20
query19	1.91	1.87	1.97
query20	0.02	0.02	0.01
query21	15.36	0.60	0.56
query22	2.41	2.41	1.70
query23	17.19	0.86	0.86
query24	3.30	0.83	1.85
query25	0.19	0.20	0.22
query26	0.57	0.14	0.13
query27	0.04	0.04	0.04
query28	9.94	1.12	1.08
query29	12.54	3.27	3.28
query30	0.25	0.07	0.06
query31	2.85	0.39	0.38
query32	3.25	0.48	0.45
query33	3.08	3.05	3.13
query34	16.73	4.46	4.52
query35	4.46	4.50	4.47
query36	0.70	0.48	0.48
query37	0.10	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.12	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.27 s
Total hot run time: 32.65 s

Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 27, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@starocean999 starocean999 merged commit 5e6f8bb into apache:master Dec 27, 2024
24 of 25 checks passed
@shuke987
Copy link
Collaborator

After this pr, dropping column in mv is not allowed

hello-stephen pushed a commit that referenced this pull request Jan 7, 2025
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx
#44058 

Problem Summary:
behavior change in #44058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/behavior-changed reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants