-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](nereids) enhance PUSH_DOWN_AGG_THROUGH_JOIN_ONE_SIDE #43856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
1 similar comment
run buildall |
starocean999
previously approved these changes
Nov 15, 2024
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Indicates a PR has been approved by one committer.
reviewed
labels
Nov 15, 2024
PR approved by anyone and no changes requested. |
run buildall |
github-actions
bot
removed
the
approved
Indicates a PR has been approved by one committer.
label
Nov 18, 2024
run buildall |
run feut |
englefly
force-pushed
the
push-agg-join
branch
from
November 27, 2024 02:59
697f80a
to
eae497f
Compare
run buildall |
run cloud_p0 |
starocean999
approved these changes
Nov 28, 2024
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Nov 28, 2024
PR approved by at least one committer and no changes requested. |
LiBinfeng-01
approved these changes
Nov 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
### What problem does this PR solve? PUSH_DOWN_AGG_THROUGH_JOIN_ONE_SIDE has some restrictions do not support count(*) do not support join with other join conditions do not support the project between agg and join that contains non-slot expressions this pr removes above restrictions for pattern: agg-project-join
morrySnow
pushed a commit
that referenced
this pull request
Dec 6, 2024
…#43856 (#45066) Cherry-picked from #43856 Co-authored-by: minghong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
PUSH_DOWN_AGG_THROUGH_JOIN_ONE_SIDE has some restrictions
do not support count(*)
do not support join with other join conditions
do not support the project between agg and join that contains non-slot expressions
this pr removes above restrictions for pattern: agg-project-join
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)