-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](agg function)Use float32 instead of float64 as a parameter in percentile_approx. #43593
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
||
#pragma once | ||
|
||
#include <glog/logging.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
#include <glog/logging.h>
^
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 51453 ms
|
5e66a06
to
69fa500
Compare
run buildall |
TeamCity be ut coverage result: |
What problem does this PR solve?
This issue was identified by the "compile_check".
In the functions percentile_approx and percentile_approx_weighted, the parameter type is Float64, but the internal TDigest used in these functions operates with Float32.
This results in type conversion every time the function is executed.
Modifying the function definition would cause compatibility issues for upgrades and downgrades, so both versions of the code are retained here.
test pr #43592
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)