[opt](nereids) support pushing down aggr distinct through join #43380
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
xzj7019
force-pushed
the
pushdown_agg_distinct
branch
2 times, most recently
from
7a772d1 to
29c1de5
Compare
|
run buildall |
xzj7019
changed the title
xzj7019
force-pushed
the
pushdown_agg_distinct
branch
from
29c1de5 to
964514c
Compare
|
run buildall |
| .when(agg -> agg.child().child().getOtherJoinConjuncts().isEmpty()) | ||
| .when(agg -> !agg.isGenerated()) | ||
| .whenNot(agg -> agg.getAggregateFunctions().isEmpty()) | ||
| .whenNot(agg -> agg.child().children().stream().anyMatch(p -> p instanceof LogicalAggregate)) |
There was a problem hiding this comment.
agg -> agg.child().children().stream().anyMatch(p -> p instanceof LogicalAggregate) , this is always false.
There was a problem hiding this comment.
thx, should be changed to .whenNot(agg -> agg.child()
.child(0).children().stream().anyMatch(p -> p instanceof LogicalAggregate))
| leftFuncs.forEach(func -> { | ||
| Alias alias = func.alias("PDADT_" + func.getName()); | ||
| leftSlotToOutput.put((Slot) func.child(0), alias); | ||
| }); |
There was a problem hiding this comment.
map leftSlotToOutput value seems to be useless
xzj7019
force-pushed
the
pushdown_agg_distinct
branch
from
964514c to
e99aa8c
Compare
|
run buildall |
|
PR approved by anyone and no changes requested. |
xzj7019
force-pushed
the
pushdown_agg_distinct
branch
from
e99aa8c to
8076eb0
Compare
|
run buildall |
|
run cloud_p0 |
1 similar comment
|
run cloud_p0 |
| public List<Rule> buildRules() { | ||
| return ImmutableList.of( | ||
| logicalAggregate(logicalProject(innerLogicalJoin())) | ||
| .when(agg -> agg.child().isAllSlots()) |
There was a problem hiding this comment.
agg.child().isAllSlots()
is this restriction too strong?
There was a problem hiding this comment.
aggr with distinct pushing down has special rewrite logic and restrict this case carefully by safety
| return ImmutableList.of( | ||
| logicalAggregate(logicalProject(innerLogicalJoin())) | ||
| .when(agg -> agg.child().isAllSlots()) | ||
| .when(agg -> agg.child().child().getOtherJoinConjuncts().isEmpty()) |
There was a problem hiding this comment.
"getOtherJoinConjuncts().isEmpty()"
how about remove this?
There was a problem hiding this comment.
leave this clean up task for the whole series of aggr pushing down rules
|
why it is called oneSide? it could push down through both sides |
|
run cloud_p0 |
xzj7019
force-pushed
the
pushdown_agg_distinct
branch
from
8076eb0 to
b243038
Compare
|
run buildall |
|
run cloud_p0 |
xzj7019
force-pushed
the
pushdown_agg_distinct
branch
from
bf3e09d to
5e048db
Compare
|
run buildall |
xzj7019
force-pushed
the
pushdown_agg_distinct
branch
from
c85ccfa to
9e4d53c
Compare
|
run buildall |
|
run p0 |
1 similar comment
|
run p0 |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
… join #43380 (#45067) Cherry-picked from #43380 Co-authored-by: xzj7019 <[email protected]>
What problem does this PR solve?
support pushing down agg distinct through join on one side.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Release note
None
Check List (For Reviewer who merge this PR)