Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](backup) fix backup confict with ddl #42872

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[fix](backup) fix backup confict with ddl #42872

wants to merge 6 commits into from

Conversation

justfortaste
Copy link
Contributor

@justfortaste justfortaste commented Oct 29, 2024 •
edited
Loading

problem

backup job failed with failed to get tablet

  1. begin backup job
  2. truncate table during backup snaphot
  3. ReportHander delete tablet
  4. backup make_snapshot get_tablet failed

solution

The following DDL is forbidden during backup snapshot

  • drop db
  • drop table
  • truncate table
  • drop partition

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

dataroaring
dataroaring requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe why and add cases.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

lide-reed
lide-reed previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justfortaste
[fix](backup) fix backup confict with ddl
a628a9e 
The following DDL is forbidden during backup snapshot
- drop db
- drop table
- truncate table
- drop partition
@justfortaste
add testcase
7e615b6
@justfortaste
fix testcase
e2e27a9
@justfortaste justfortaste force-pushed the fix_backup_confict_with_ddl branch from 2923cc6 to e034f1d Compare December 5, 2024 15:34
@justfortaste
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.48% (10005/26003)
Line Coverage: 29.51% (83895/284319)
Region Coverage: 28.61% (43115/150710)
Branch Coverage: 25.20% (21916/86966)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e034f1dab3a59d463d630ce90d415e9233846ad3_e034f1dab3a59d463d630ce90d415e9233846ad3/report/index.html

@justfortaste justfortaste force-pushed the fix_backup_confict_with_ddl branch from e034f1d to 348b4b7 Compare December 7, 2024 02:47
@justfortaste
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.49% (10007/26002)
Line Coverage: 29.50% (83888/284390)
Region Coverage: 28.60% (43122/150751)
Branch Coverage: 25.20% (21919/86986)
Coverage Report: http://coverage.selectdb-in.cc/coverage/348b4b71330bc22313e03e1e1d72763a27ba6018_348b4b71330bc22313e03e1e1d72763a27ba6018/report/index.html

@justfortaste
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.49% (10007/26002)
Line Coverage: 29.51% (83919/284390)
Region Coverage: 28.60% (43121/150751)
Branch Coverage: 25.20% (21921/86986)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1a817b600817dcd5a8d863071ac4ba8d637e8d20_1a817b600817dcd5a8d863071ac4ba8d637e8d20/report/index.html

@justfortaste
fix review2
30c6ec5 
job instanceof BackupJob
@justfortaste justfortaste force-pushed the fix_backup_confict_with_ddl branch from 1a817b6 to 30c6ec5 Compare December 8, 2024 04:34
@justfortaste
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.48% (10006/26002)
Line Coverage: 29.51% (83911/284391)
Region Coverage: 28.60% (43118/150758)
Branch Coverage: 25.20% (21918/86988)
Coverage Report: http://coverage.selectdb-in.cc/coverage/30c6ec5a4c93a2518f4bcc2967b09083f50b8a44_30c6ec5a4c93a2518f4bcc2967b09083f50b8a44/report/index.html

@justfortaste
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.49% (10007/26002)
Line Coverage: 29.50% (83887/284391)
Region Coverage: 28.61% (43127/150758)
Branch Coverage: 25.20% (21921/86988)
Coverage Report: http://coverage.selectdb-in.cc/coverage/30c6ec5a4c93a2518f4bcc2967b09083f50b8a44_30c6ec5a4c93a2518f4bcc2967b09083f50b8a44/report/index.html

@justfortaste
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.76% (10109/26082)
Line Coverage: 29.70% (84875/285767)
Region Coverage: 28.76% (43565/151452)
Branch Coverage: 25.32% (22133/87418)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cbf09f01cb03fc681f40326c55df3dfc3eb0a06b_cbf09f01cb03fc681f40326c55df3dfc3eb0a06b/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xy720 xy720 xy720 left review comments

@lide-reed lide-reed lide-reed left review comments

@dataroaring dataroaring Awaiting requested review from dataroaring

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justfortaste @doris-robot @lide-reed @xy720 @dataroaring