[env](compile)open compile check in pipeline op #42202
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
1 similar comment
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #error The handling of compile_check_begin.h and compile_check_end.h is not done correctly. | ||
| #endif | ||
|
|
||
| #define COMPILE_CHECK |
There was a problem hiding this comment.
warning: macro is not used [clang-diagnostic-unused-macros]
#define COMPILE_CHECK
^
|
TeamCity be ut coverage result: |
Mryange
force-pushed
the
compile_check-5
branch
from
5c4feaf to
fbbca2c
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
be/src/pipeline/exec/join/join_op.h
Outdated
| @@ -43,7 +44,7 @@ namespace doris::pipeline { | |||
| * RowRefListWithFlags is a list of many RowRefWithFlags. This means each row will have different visited flags. It's used for join operation which has `other_conjuncts`. | |||
| */ | |||
| struct RowRef { | |||
| uint32_t row_num = 0; | |||
| size_t row_num = 0; | |||
There was a problem hiding this comment.
The change would affect performance; it cannot be done. should use uint32_t
| @@ -288,7 +290,7 @@ Status TableFunctionOperatorX::open(doris::RuntimeState* state) { | |||
| } | |||
| } | |||
|
|
|||
| for (size_t i = 0; i < _child_slots.size(); i++) { | |||
There was a problem hiding this comment.
the _child_slot.size() is size_t why not change to int
Mryange
force-pushed
the
compile_check-5
branch
from
fbbca2c to
e67b46a
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
Mryange
force-pushed
the
compile_check-5
branch
from
e67b46a to
8a6449c
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
Mryange
force-pushed
the
compile_check-5
branch
from
8a6449c to
e9c814d
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
Proposed changes
Issue Number: close #xxx