Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement](scan) use loop to instead recursion on Level1Iterator::_normal_next #38005

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

Proposed changes

use loop to instead recursion on Level1Iterator::_normal_next

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 18, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit a5dd5a9 into apache:master Jul 19, 2024
27 of 30 checks passed
dataroaring pushed a commit that referenced this pull request Jul 22, 2024
…_normal_next (#38005)

## Proposed changes
use loop to instead recursion on Level1Iterator::_normal_next
@yiguolei yiguolei added the p0_c label Dec 23, 2024
yiguolei pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.1-merged p0_c reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants