[Enhancement] (nereids)implement adminCheckTabletsCommand in nereids… #44701

rijeshkp · 2024-11-27T16:14:03Z

… #42843

What problem does this PR solve?

Issue Number: close #42843

Related PR: #

Problem Summary:
Support ADMIN CHECK tabletlist command in nereids

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

doris-robot · 2024-11-27T16:14:09Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

rijeshkp · 2024-12-04T13:43:15Z

run buildall

doris-robot · 2024-12-04T14:22:16Z

TPC-H: Total hot run time: 39770 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4236a9e41b3fd1e0f8e4fbde24e9376528d8d39a, data reload: false

------ Round 1 ----------------------------------
q1	17445	7494	7197	7197
q2	2039	184	176	176
q3	10562	1100	1170	1100
q4	10549	721	751	721
q5	7617	2745	2626	2626
q6	242	152	152	152
q7	985	619	594	594
q8	9245	1823	1844	1823
q9	6597	6513	6472	6472
q10	6999	2309	2302	2302
q11	449	259	261	259
q12	419	234	222	222
q13	17763	3060	3000	3000
q14	240	210	218	210
q15	575	522	521	521
q16	626	594	583	583
q17	970	588	550	550
q18	7228	6591	6662	6591
q19	1353	984	958	958
q20	467	177	185	177
q21	4029	3258	3235	3235
q22	385	308	301	301
Total cold run time: 106784 ms
Total hot run time: 39770 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7209	7187	7229	7187
q2	328	234	223	223
q3	2914	2792	2923	2792
q4	2079	1876	1883	1876
q5	5644	5695	5638	5638
q6	229	148	141	141
q7	2220	1808	1843	1808
q8	3359	3574	3488	3488
q9	8976	9084	8991	8991
q10	3606	3541	3546	3541
q11	579	503	495	495
q12	838	608	569	569
q13	12400	3181	3190	3181
q14	311	282	263	263
q15	570	542	517	517
q16	710	641	648	641
q17	1839	1598	1589	1589
q18	8293	7751	7640	7640
q19	1698	1498	1628	1498
q20	2134	1897	1883	1883
q21	5622	5445	5382	5382
q22	662	564	595	564
Total cold run time: 72220 ms
Total hot run time: 59907 ms

doris-robot · 2024-12-04T14:34:54Z

TPC-DS: Total hot run time: 198189 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4236a9e41b3fd1e0f8e4fbde24e9376528d8d39a, data reload: false

query1	1500	967	969	967
query2	6208	2125	2092	2092
query3	11017	4425	4337	4337
query4	67457	28407	23670	23670
query5	4922	459	461	459
query6	403	191	196	191
query7	5485	297	298	297
query8	324	237	241	237
query9	8327	2717	2707	2707
query10	448	245	254	245
query11	17052	15484	15945	15484
query12	165	107	111	107
query13	1447	456	425	425
query14	10091	7403	7684	7403
query15	209	182	197	182
query16	7063	466	491	466
query17	1211	565	551	551
query18	1826	317	301	301
query19	210	159	154	154
query20	115	115	111	111
query21	204	103	101	101
query22	4781	4724	4557	4557
query23	34919	34545	34680	34545
query24	5411	2672	2545	2545
query25	482	379	405	379
query26	660	154	162	154
query27	1996	312	282	282
query28	4303	2448	2430	2430
query29	685	410	415	410
query30	206	150	147	147
query31	1028	857	855	855
query32	62	56	57	56
query33	407	294	319	294
query34	937	506	525	506
query35	934	753	757	753
query36	1118	949	971	949
query37	123	74	77	74
query38	4441	4451	4446	4446
query39	1515	1514	1496	1496
query40	208	100	99	99
query41	44	42	43	42
query42	115	101	99	99
query43	550	495	487	487
query44	1235	821	815	815
query45	189	177	172	172
query46	1154	708	727	708
query47	2021	1933	1931	1931
query48	440	315	337	315
query49	740	399	389	389
query50	855	387	389	387
query51	7547	7209	7164	7164
query52	97	82	88	82
query53	259	187	187	187
query54	509	390	395	390
query55	79	74	77	74
query56	254	243	229	229
query57	1308	1131	1122	1122
query58	217	201	205	201
query59	3225	3112	2920	2920
query60	281	250	242	242
query61	113	104	104	104
query62	796	676	666	666
query63	214	182	185	182
query64	1399	666	651	651
query65	3264	3213	3197	3197
query66	708	295	297	295
query67	15891	15797	15576	15576
query68	3932	609	570	570
query69	426	256	253	253
query70	1121	1141	1134	1134
query71	351	249	254	249
query72	6489	4142	4208	4142
query73	757	367	357	357
query74	10283	9157	9091	9091
query75	3354	2637	2640	2637
query76	1885	1118	1101	1101
query77	503	260	281	260
query78	10316	9453	9336	9336
query79	1285	602	599	599
query80	861	451	439	439
query81	499	232	229	229
query82	1327	116	124	116
query83	189	142	145	142
query84	281	65	72	65
query85	856	301	303	301
query86	337	274	291	274
query87	4897	4484	4520	4484
query88	3204	2295	2193	2193
query89	422	300	282	282
query90	2024	189	250	189
query91	134	103	104	103
query92	64	50	49	49
query93	1284	521	525	521
query94	837	290	287	287
query95	343	249	245	245
query96	622	274	277	274
query97	2864	2704	2662	2662
query98	229	190	199	190
query99	1588	1330	1324	1324
Total cold run time: 316968 ms
Total hot run time: 198189 ms

doris-robot · 2024-12-04T14:40:24Z

ClickBench: Total hot run time: 33.32 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4236a9e41b3fd1e0f8e4fbde24e9376528d8d39a, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.42	0.43	0.40
query6	1.17	0.66	0.65
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.53
query10	0.55	0.54	0.58
query11	0.14	0.11	0.10
query12	0.13	0.11	0.11
query13	0.61	0.60	0.60
query14	2.72	2.87	2.72
query15	0.91	0.84	0.84
query16	0.38	0.40	0.37
query17	1.07	1.08	1.07
query18	0.22	0.20	0.22
query19	1.94	1.84	1.99
query20	0.02	0.00	0.02
query21	15.38	0.59	0.59
query22	2.55	2.22	2.16
query23	17.02	1.00	0.89
query24	3.18	1.88	1.20
query25	0.24	0.12	0.23
query26	0.37	0.14	0.14
query27	0.04	0.05	0.04
query28	9.97	1.09	1.07
query29	12.62	3.27	3.22
query30	0.25	0.07	0.06
query31	2.97	0.38	0.38
query32	3.27	0.46	0.46
query33	3.08	3.11	3.06
query34	16.94	4.49	4.50
query35	4.48	4.47	4.52
query36	0.67	0.47	0.48
query37	0.08	0.06	0.05
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.14
query41	0.08	0.02	0.03
query42	0.03	0.02	0.03
query43	0.04	0.02	0.03
Total cold run time: 106.38 s
Total hot run time: 33.32 s

rijeshkp · 2024-12-05T17:27:22Z

run buildall

doris-robot · 2024-12-05T18:12:29Z

TPC-H: Total hot run time: 39875 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c6d078146cf6643ab06fb2f531e2dcc271c2b07f, data reload: false

------ Round 1 ----------------------------------
q1	17576	7462	7320	7320
q2	2040	183	175	175
q3	10607	1048	1223	1048
q4	10571	747	710	710
q5	7591	2646	2626	2626
q6	242	150	151	150
q7	999	620	613	613
q8	9252	1918	1923	1918
q9	6700	6489	6443	6443
q10	6978	2327	2324	2324
q11	485	263	258	258
q12	413	239	217	217
q13	17788	3065	3000	3000
q14	243	208	214	208
q15	567	519	525	519
q16	653	574	588	574
q17	971	550	509	509
q18	7225	6814	6536	6536
q19	1332	1030	1037	1030
q20	465	180	180	180
q21	4110	3233	3205	3205
q22	378	319	312	312
Total cold run time: 107186 ms
Total hot run time: 39875 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7311	7297	7248	7248
q2	330	230	233	230
q3	2930	2796	3008	2796
q4	2049	1819	1813	1813
q5	5681	5689	5637	5637
q6	225	146	143	143
q7	2268	1821	1827	1821
q8	3403	3571	3495	3495
q9	8999	9131	9110	9110
q10	3638	3519	3557	3519
q11	597	525	520	520
q12	813	615	616	615
q13	12730	3381	3258	3258
q14	329	273	291	273
q15	565	542	543	542
q16	687	658	619	619
q17	1872	1630	1606	1606
q18	8423	7848	7691	7691
q19	2042	1518	1542	1518
q20	2148	1881	1896	1881
q21	5654	5408	5629	5408
q22	630	587	602	587
Total cold run time: 73324 ms
Total hot run time: 60330 ms

doris-robot · 2024-12-05T18:25:12Z

TPC-DS: Total hot run time: 198016 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c6d078146cf6643ab06fb2f531e2dcc271c2b07f, data reload: false

query1	1535	990	964	964
query2	6256	2070	1990	1990
query3	10942	4444	4460	4444
query4	66666	29388	23564	23564
query5	5022	477	451	451
query6	408	184	192	184
query7	5611	310	296	296
query8	333	225	226	225
query9	8999	2740	2695	2695
query10	430	253	240	240
query11	17584	15470	15866	15470
query12	157	98	105	98
query13	1518	408	423	408
query14	10592	7271	7162	7162
query15	218	199	188	188
query16	7065	494	476	476
query17	1288	607	602	602
query18	1866	336	313	313
query19	217	165	173	165
query20	124	114	117	114
query21	223	112	107	107
query22	4797	4599	4349	4349
query23	35215	34472	36007	34472
query24	6037	2597	2503	2503
query25	479	415	400	400
query26	771	162	160	160
query27	1954	306	296	296
query28	4496	2511	2491	2491
query29	661	432	419	419
query30	212	150	146	146
query31	1020	886	855	855
query32	66	58	56	56
query33	454	316	312	312
query34	933	550	534	534
query35	881	762	763	762
query36	1126	968	966	966
query37	124	74	74	74
query38	4523	4414	4442	4414
query39	1553	1498	1446	1446
query40	209	102	101	101
query41	43	42	46	42
query42	116	101	99	99
query43	551	508	505	505
query44	1201	844	831	831
query45	195	177	173	173
query46	1155	730	768	730
query47	2052	1940	1927	1927
query48	433	323	329	323
query49	725	405	404	404
query50	836	405	404	404
query51	7457	7184	7125	7125
query52	98	89	92	89
query53	256	177	183	177
query54	513	402	393	393
query55	84	73	74	73
query56	258	239	235	235
query57	1298	1129	1109	1109
query58	213	210	235	210
query59	3197	2970	2839	2839
query60	268	250	245	245
query61	140	101	102	101
query62	780	678	656	656
query63	213	201	186	186
query64	2179	664	647	647
query65	3315	3193	3252	3193
query66	652	301	319	301
query67	16040	15830	15655	15655
query68	4025	588	586	586
query69	414	259	254	254
query70	1214	1139	1174	1139
query71	334	250	248	248
query72	6085	4100	4065	4065
query73	775	372	361	361
query74	9942	9074	9145	9074
query75	3400	2684	2656	2656
query76	2015	1173	1175	1173
query77	472	288	302	288
query78	10633	9551	9483	9483
query79	1230	637	609	609
query80	833	451	468	451
query81	500	244	230	230
query82	424	126	122	122
query83	174	152	142	142
query84	279	73	72	72
query85	841	308	295	295
query86	346	289	298	289
query87	4754	4683	4536	4536
query88	3821	2268	2211	2211
query89	428	297	293	293
query90	1948	191	191	191
query91	140	104	105	104
query92	71	50	48	48
query93	1467	542	552	542
query94	696	293	300	293
query95	353	249	259	249
query96	608	279	284	279
query97	2865	2654	2709	2654
query98	229	190	194	190
query99	1618	1305	1325	1305
Total cold run time: 319767 ms
Total hot run time: 198016 ms

doris-robot · 2024-12-05T18:30:42Z

ClickBench: Total hot run time: 32.98 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c6d078146cf6643ab06fb2f531e2dcc271c2b07f, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.03
query3	0.24	0.07	0.07
query4	1.63	0.10	0.11
query5	0.41	0.42	0.42
query6	1.14	0.67	0.65
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.59	0.50	0.50
query10	0.56	0.55	0.59
query11	0.14	0.11	0.11
query12	0.14	0.12	0.12
query13	0.61	0.62	0.60
query14	2.69	2.72	2.73
query15	0.90	0.83	0.83
query16	0.39	0.39	0.38
query17	1.07	1.07	1.05
query18	0.22	0.21	0.21
query19	1.88	1.83	1.99
query20	0.02	0.01	0.01
query21	15.38	0.58	0.58
query22	2.49	2.56	1.64
query23	17.10	0.90	0.77
query24	3.35	1.76	1.36
query25	0.19	0.19	0.17
query26	0.54	0.15	0.14
query27	0.04	0.05	0.04
query28	9.63	1.11	1.08
query29	12.54	3.23	3.22
query30	0.24	0.06	0.07
query31	2.86	0.38	0.38
query32	3.27	0.46	0.46
query33	2.96	3.06	3.20
query34	17.04	4.47	4.49
query35	4.51	4.50	4.51
query36	0.67	0.48	0.49
query37	0.09	0.05	0.06
query38	0.05	0.03	0.03
query39	0.03	0.03	0.02
query40	0.17	0.14	0.14
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.1 s
Total hot run time: 32.98 s

...re/src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminCheckTabletsCommand.java

starocean999 · 2024-12-06T02:20:04Z

...re/src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminCheckTabletsCommand.java

+    }
+
+    @Override
+    public RedirectStatus toRedirectStatus() {


Suggested change

public RedirectStatus toRedirectStatus() {

no need to override toRedirectStatus if implements ForwardNoSync

Resolved. Please review

starocean999 · 2024-12-06T02:22:32Z

...re/src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminCheckTabletsCommand.java

+    public <R, C> R accept(PlanVisitor<R, C> visitor, C context) {
+        return visitor.visitAdminCheckTabletsCommand(this, context);
+    }
+


override checkSupportedInCloudMode method and implement as checkDdlStmtSupported() method in DdlExecutor.java like bellow

@Override protected void checkSupportedInCloudMode(ConnectContext ctx) throws DdlException { LOG.info("AdminCheckTabletsCommand not supported in cloud mode"); throw new DdlException("Unsupported operation"); }

Resolved. Please review

rijeshkp · 2024-12-06T10:43:46Z

run buildall

doris-robot · 2024-12-06T11:02:56Z

TPC-H: Total hot run time: 40284 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 80f24b977fbba2b429967d7c2e45beba3b44e5c5, data reload: false

------ Round 1 ----------------------------------
q1	17595	7520	7319	7319
q2	2064	173	173	173
q3	10556	1146	1296	1146
q4	10243	731	758	731
q5	7599	2731	2673	2673
q6	243	152	153	152
q7	1006	625	640	625
q8	9264	1867	1967	1867
q9	6680	6578	6499	6499
q10	7011	2307	2339	2307
q11	463	260	265	260
q12	433	226	222	222
q13	17761	3026	3044	3026
q14	249	221	239	221
q15	565	526	522	522
q16	643	591	585	585
q17	984	606	544	544
q18	7452	6843	6763	6763
q19	1345	1069	981	981
q20	474	183	181	181
q21	4193	3173	3189	3173
q22	383	318	314	314
Total cold run time: 107206 ms
Total hot run time: 40284 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7313	7289	7369	7289
q2	330	235	230	230
q3	2881	2850	2989	2850
q4	2155	1917	1860	1860
q5	5599	5655	5642	5642
q6	226	144	142	142
q7	2205	1796	1883	1796
q8	3418	3563	3510	3510
q9	9000	9067	9017	9017
q10	3616	3573	3580	3573
q11	594	517	523	517
q12	803	627	633	627
q13	12153	3142	3237	3142
q14	319	283	277	277
q15	588	522	510	510
q16	649	626	614	614
q17	1805	1588	1571	1571
q18	8005	7486	7396	7396
q19	1669	1531	1381	1381
q20	2048	1876	1811	1811
q21	5481	5223	5176	5176
q22	652	558	548	548
Total cold run time: 71509 ms
Total hot run time: 59479 ms

doris-robot · 2024-12-06T11:15:03Z

TPC-DS: Total hot run time: 191418 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 80f24b977fbba2b429967d7c2e45beba3b44e5c5, data reload: false

query1	1169	375	385	375
query2	6528	2171	2085	2085
query3	6711	225	208	208
query4	34025	23664	23622	23622
query5	4349	488	481	481
query6	300	201	179	179
query7	4646	309	298	298
query8	317	232	233	232
query9	9601	2748	2750	2748
query10	448	262	264	262
query11	17970	15377	15297	15297
query12	156	105	112	105
query13	1655	416	404	404
query14	10201	6698	7601	6698
query15	319	187	178	178
query16	8206	467	500	467
query17	1827	596	553	553
query18	2146	294	281	281
query19	371	147	143	143
query20	117	109	111	109
query21	210	99	98	98
query22	4779	4223	4480	4223
query23	34884	34148	34286	34148
query24	11287	2441	2415	2415
query25	666	382	384	382
query26	1790	151	152	151
query27	2763	282	283	282
query28	8006	2437	2460	2437
query29	1019	408	403	403
query30	293	157	157	157
query31	1035	821	837	821
query32	102	60	62	60
query33	782	293	288	288
query34	985	505	545	505
query35	890	747	746	746
query36	1076	949	948	948
query37	131	74	68	68
query38	4279	4332	4250	4250
query39	1477	1467	1418	1418
query40	285	100	99	99
query41	48	49	50	49
query42	106	96	97	96
query43	557	474	506	474
query44	1294	805	797	797
query45	200	162	162	162
query46	1164	698	703	698
query47	1960	1868	1844	1844
query48	407	329	328	328
query49	1240	396	444	396
query50	789	382	383	382
query51	7224	7092	7040	7040
query52	103	95	95	95
query53	251	184	181	181
query54	1315	411	416	411
query55	78	75	84	75
query56	273	230	255	230
query57	1207	1131	1124	1124
query58	228	218	222	218
query59	3261	3017	3044	3017
query60	288	243	258	243
query61	116	108	107	107
query62	879	666	700	666
query63	210	194	199	194
query64	5118	665	630	630
query65	3294	3216	3238	3216
query66	1467	308	313	308
query67	15967	15771	15630	15630
query68	5214	559	602	559
query69	407	261	250	250
query70	1155	1081	1095	1081
query71	323	250	255	250
query72	6408	4009	4089	4009
query73	767	364	359	359
query74	10449	8937	9023	8937
query75	3482	2651	2651	2651
query76	2971	1188	1126	1126
query77	516	281	288	281
query78	10440	9568	9511	9511
query79	2451	622	632	622
query80	1073	440	437	437
query81	520	234	231	231
query82	836	116	121	116
query83	245	148	154	148
query84	232	72	68	68
query85	1396	309	304	304
query86	430	300	313	300
query87	4703	4573	4626	4573
query88	4044	2224	2188	2188
query89	419	310	295	295
query90	2132	190	185	185
query91	142	103	106	103
query92	64	52	51	51
query93	1567	534	545	534
query94	995	295	301	295
query95	356	249	244	244
query96	619	278	279	278
query97	2852	2684	2699	2684
query98	216	244	194	194
query99	1547	1329	1319	1319
Total cold run time: 305816 ms
Total hot run time: 191418 ms

doris-robot · 2024-12-06T11:20:32Z

ClickBench: Total hot run time: 32.17 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 80f24b977fbba2b429967d7c2e45beba3b44e5c5, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.04
query3	0.24	0.07	0.08
query4	1.63	0.10	0.11
query5	0.43	0.41	0.44
query6	1.16	0.67	0.66
query7	0.02	0.01	0.02
query8	0.05	0.03	0.03
query9	0.55	0.51	0.50
query10	0.56	0.56	0.55
query11	0.14	0.10	0.11
query12	0.14	0.11	0.12
query13	0.61	0.61	0.61
query14	2.85	2.68	2.85
query15	0.90	0.82	0.83
query16	0.39	0.39	0.39
query17	1.05	1.00	0.98
query18	0.22	0.22	0.22
query19	1.90	1.90	2.02
query20	0.01	0.01	0.01
query21	15.39	0.60	0.59
query22	2.57	2.23	1.77
query23	17.25	0.89	0.80
query24	3.26	1.18	0.48
query25	0.19	0.23	0.26
query26	0.37	0.14	0.14
query27	0.05	0.06	0.05
query28	10.96	1.10	1.07
query29	12.59	3.20	3.19
query30	0.24	0.06	0.06
query31	2.87	0.38	0.37
query32	3.27	0.46	0.47
query33	3.04	3.09	3.02
query34	16.77	4.43	4.50
query35	4.57	4.53	4.52
query36	0.68	0.47	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.12	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.48 s
Total hot run time: 32.17 s

github-actions · 2024-12-06T12:51:57Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-12-06T12:52:00Z

PR approved by anyone and no changes requested.

rijeshkp force-pushed the AdminCheckTabletsNereids branch 5 times, most recently from ea9d777 to 4236a9e Compare December 4, 2024 13:34

rijeshkp marked this pull request as ready for review December 4, 2024 16:10

rijeshkp force-pushed the AdminCheckTabletsNereids branch 2 times, most recently from 0f3b02f to c6d0781 Compare December 5, 2024 15:35

starocean999 reviewed Dec 6, 2024

View reviewed changes

...re/src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminCheckTabletsCommand.java Outdated Show resolved Hide resolved

starocean999 reviewed Dec 6, 2024

View reviewed changes

[Enhancement] (nereids)implement adminCheckTabletsCommand in nereids

80f24b9

rijeshkp force-pushed the AdminCheckTabletsNereids branch from bd5601a to 80f24b9 Compare December 6, 2024 08:48

starocean999 approved these changes Dec 6, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024

github-actions bot added the reviewed label Dec 6, 2024

LiBinfeng-01 approved these changes Dec 6, 2024

View reviewed changes

starocean999 approved these changes Dec 9, 2024

View reviewed changes

starocean999 merged commit 2b1264c into apache:master Dec 9, 2024
27 of 31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] (nereids)implement adminCheckTabletsCommand in nereids… #44701

[Enhancement] (nereids)implement adminCheckTabletsCommand in nereids… #44701

rijeshkp commented Nov 27, 2024 •

edited

Loading

doris-robot commented Nov 27, 2024

rijeshkp commented Dec 4, 2024

doris-robot commented Dec 4, 2024

doris-robot commented Dec 4, 2024

doris-robot commented Dec 4, 2024

rijeshkp commented Dec 5, 2024

doris-robot commented Dec 5, 2024

doris-robot commented Dec 5, 2024

doris-robot commented Dec 5, 2024

starocean999 Dec 6, 2024

rijeshkp Dec 6, 2024

starocean999 Dec 6, 2024

rijeshkp Dec 6, 2024

rijeshkp commented Dec 6, 2024

doris-robot commented Dec 6, 2024

doris-robot commented Dec 6, 2024

doris-robot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

[Enhancement] (nereids)implement adminCheckTabletsCommand in nereids… #44701

[Enhancement] (nereids)implement adminCheckTabletsCommand in nereids… #44701

Conversation

rijeshkp commented Nov 27, 2024 • edited Loading

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

doris-robot commented Nov 27, 2024

rijeshkp commented Dec 4, 2024

doris-robot commented Dec 4, 2024

doris-robot commented Dec 4, 2024

doris-robot commented Dec 4, 2024

rijeshkp commented Dec 5, 2024

doris-robot commented Dec 5, 2024

doris-robot commented Dec 5, 2024

doris-robot commented Dec 5, 2024

starocean999 Dec 6, 2024

Choose a reason for hiding this comment

rijeshkp Dec 6, 2024

Choose a reason for hiding this comment

starocean999 Dec 6, 2024

Choose a reason for hiding this comment

rijeshkp Dec 6, 2024

Choose a reason for hiding this comment

rijeshkp commented Dec 6, 2024

doris-robot commented Dec 6, 2024

doris-robot commented Dec 6, 2024

doris-robot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

rijeshkp commented Nov 27, 2024 •

edited

Loading