Skip to content

Commit

Permalink
[fix](row store) forbit short circuit row store cache temporaryly
Browse files Browse the repository at this point in the history
The cache eviction may not be in time
  • Loading branch information
eldenmoon committed Dec 24, 2024
1 parent a16b682 commit f06df46
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions be/src/service/point_query_executor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ Status PointQueryExecutor::_lookup_row_key() {
std::vector<std::unique_ptr<SegmentCacheHandle>> segment_caches(specified_rowsets.size());
for (size_t i = 0; i < _row_read_ctxs.size(); ++i) {
RowLocation location;
if (!config::disable_storage_row_cache) {
if (!config::disable_storage_row_cache && !config::is_cloud_mode()) {
RowCache::CacheHandle cache_handle;
auto hit_cache = RowCache::instance()->lookup(
{_tablet->tablet_id(), _row_read_ctxs[i]._primary_key}, &cache_handle);
Expand Down Expand Up @@ -448,7 +448,7 @@ Status PointQueryExecutor::_lookup_row_data() {
std::string value;
// fill block by row store
if (_reusable->rs_column_uid() != -1) {
bool use_row_cache = !config::disable_storage_row_cache;
bool use_row_cache = !config::disable_storage_row_cache && !config::is_cloud_mode();
RETURN_IF_ERROR(_tablet->lookup_row_data(
_row_read_ctxs[i]._primary_key, _row_read_ctxs[i]._row_location.value(),
*(_row_read_ctxs[i]._rowset_ptr), _reusable->tuple_desc(),
Expand Down

0 comments on commit f06df46

Please sign in to comment.