fix second parameter of first_value/second_value is not constant lead…

…ing to be core
apache · Dec 9, 2024 · eb4e1ba · eb4e1ba
1 parent 3629ff6
commit eb4e1ba
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/WindowFunctionChecker.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/WindowFunctionChecker.java
@@ -316,8 +316,13 @@ public Lead visitLead(Lead lead, Void ctx) {
      */
     @Override
     public FirstOrLastValue visitFirstValue(FirstValue firstValue, Void ctx) {
-        if (firstValue.arity() == 2 && firstValue.child(1).equals(BooleanLiteral.TRUE)) {
-            return firstValue;
+        if (2 == firstValue.arity()) {
+            if (!firstValue.child(1).isConstant()) {
+                throw new AnalysisException("The second parameter of first_value must be constant");
+            }
+            if (firstValue.child(1).equals(BooleanLiteral.TRUE)) {
+                return firstValue;
+            }
         }
         Optional<WindowFrame> windowFrame = windowExpression.getWindowFrame();
         if (windowFrame.isPresent()) {
@@ -343,6 +348,14 @@ public FirstOrLastValue visitFirstValue(FirstValue firstValue, Void ctx) {
         return firstValue;
     }
 
+    @Override
+    public FirstOrLastValue visitLastValue(LastValue lastValue, Void ctx) {
+        if (2 == lastValue.arity() && !lastValue.child(1).isConstant()) {
+            throw new AnalysisException("The second parameter of lasst_value must be constant");
+        }
+        return lastValue;
+    }
+
     /**
      * required WindowFrame: (RANGE, UNBOUNDED PRECEDING, CURRENT ROW)
      */

diff --git a/regression-test/suites/nereids_syntax_p0/window_function.groovy b/regression-test/suites/nereids_syntax_p0/window_function.groovy
@@ -279,4 +279,15 @@ suite("window_function") {
                 )t
             )a where rn=1
     """
+
+    // test first value second param is not constant
+    test {
+        sql "select first_value(c1,c1) over() from window_test"
+        exception "The second parameter of first_value must be constant"
+    }
+
+    test {
+        sql "select last_value(c1,c1) over() from window_test"
+        exception "The second parameter of first_value must be constant"
+    }
 }