-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Enhancement] (nereids)implement showStorageVaultCommand in nereids
- Loading branch information
1 parent
cf40dba
commit d6da539
Showing
6 changed files
with
138 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 90 additions & 0 deletions
90
.../src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowStorageVaultCommand.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
package org.apache.doris.nereids.trees.plans.commands; | ||
|
||
import org.apache.doris.analysis.UserIdentity; | ||
import org.apache.doris.catalog.Env; | ||
import org.apache.doris.catalog.StorageVault; | ||
import org.apache.doris.cloud.catalog.CloudEnv; | ||
import org.apache.doris.cloud.proto.Cloud; | ||
import org.apache.doris.cloud.rpc.MetaServiceProxy; | ||
import org.apache.doris.common.AnalysisException; | ||
import org.apache.doris.common.Config; | ||
import org.apache.doris.common.FeConstants; | ||
import org.apache.doris.mysql.privilege.Auth; | ||
import org.apache.doris.mysql.privilege.PrivPredicate; | ||
import org.apache.doris.nereids.trees.plans.PlanType; | ||
import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; | ||
import org.apache.doris.qe.ConnectContext; | ||
import org.apache.doris.qe.ShowResultSet; | ||
import org.apache.doris.qe.StmtExecutor; | ||
import org.apache.doris.rpc.RpcException; | ||
|
||
import java.util.List; | ||
import java.util.stream.Collectors; | ||
|
||
/** | ||
* Represents the command for SHOW STORAGE VAULT or SHOW STORAGE VAULTS. | ||
*/ | ||
public class ShowStorageVaultCommand extends ShowCommand { | ||
|
||
public ShowStorageVaultCommand() { | ||
super(PlanType.SHOW_STORAGE_VAULT_COMMAND); | ||
} | ||
|
||
private void validate() throws AnalysisException { | ||
if (Config.isNotCloudMode()) { | ||
throw new AnalysisException("Storage Vault is only supported for cloud mode"); | ||
} | ||
if (!FeConstants.runningUnitTest) { | ||
// In legacy cloud mode, some s3 back-ended storage does need to use storage vault. | ||
if (!((CloudEnv) Env.getCurrentEnv()).getEnableStorageVault()) { | ||
throw new AnalysisException("Your cloud instance doesn't support storage vault"); | ||
} | ||
} | ||
} | ||
|
||
@Override | ||
public ShowResultSet doRun(ConnectContext ctx, StmtExecutor executor) throws Exception { | ||
validate(); | ||
// [vault name, vault id, vault properties, isDefault] | ||
List<List<String>> rows; | ||
try { | ||
Cloud.GetObjStoreInfoResponse resp = MetaServiceProxy.getInstance() | ||
.getObjStoreInfo(Cloud.GetObjStoreInfoRequest.newBuilder().build()); | ||
Auth auth = Env.getCurrentEnv().getAuth(); | ||
UserIdentity user = ctx.getCurrentUserIdentity(); | ||
rows = resp.getStorageVaultList().stream() | ||
.filter(storageVault -> auth.checkStorageVaultPriv(user, storageVault.getName(), | ||
PrivPredicate.USAGE)) | ||
.map(StorageVault::convertToShowStorageVaultProperties) | ||
.collect(Collectors.toList()); | ||
if (resp.hasDefaultStorageVaultId()) { | ||
StorageVault.setDefaultVaultToShowVaultResult(rows, resp.getDefaultStorageVaultId()); | ||
} | ||
} catch (RpcException e) { | ||
throw new AnalysisException(e.getMessage()); | ||
} | ||
return new ShowResultSet(StorageVault.STORAGE_VAULT_META_DATA, rows); | ||
} | ||
|
||
@Override | ||
public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { | ||
return visitor.visitShowStorageVaultCommand(this, context); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
regression-test/suites/nereids_p0/show/test_show_storage_vault_command.groovy
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
suite("test_show_storage_vault_command", "query,storage_vault,cloud") { | ||
try { | ||
// Execute the SHOW STORAGE VAULT command and verify the output | ||
checkNereidsExecute("SHOW STORAGE VAULT") | ||
String tmp = sql """SHOW STORAGE VAULT""" | ||
log.info("Result of Show Vault is ", tmp) | ||
|
||
// Execute the SHOW STORAGE VAULTS command and verify the output | ||
checkNereidsExecute("SHOW STORAGE VAULTS") | ||
} catch (Exception e) { | ||
// Log any exceptions that occur during testing | ||
log.error("Failed to execute SHOW STORAGE VAULT command", e) | ||
throw e | ||
} | ||
} |