[minor](column) remove function "is_value_represented_by" (#44893)

### What problem does this PR solve? [minor](column) remove function "is_value_represented_by"
apache · Dec 5, 2024 · aa4318f · aa4318f
1 parent 6b4b3cb
commit aa4318f
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 33 deletions.
diff --git a/be/src/vec/data_types/data_type.h b/be/src/vec/data_types/data_type.h
@@ -151,16 +151,8 @@ class IDataType : private boost::noncopyable {
       */
     virtual bool is_value_represented_by_number() const { return false; }
 
-    /** Integers, Enums, Date, DateTime. Not nullable.
-      */
-    virtual bool is_value_represented_by_integer() const { return false; }
-
     virtual bool is_object() const { return false; }
 
-    /** Unsigned Integers, Date, DateTime. Not nullable.
-      */
-    virtual bool is_value_represented_by_unsigned_integer() const { return false; }
-
     /** Values are unambiguously identified by contents of contiguous memory region,
       *  that can be obtained by IColumn::get_data_at method.
       * Examples: numbers, Date, DateTime, String, FixedString,
@@ -386,10 +378,6 @@ inline bool is_not_decimal_but_comparable_to_decimal(const DataTypePtr& data_typ
     return which.is_int() || which.is_uint();
 }
 
-inline bool is_compilable_type(const DataTypePtr& data_type) {
-    return data_type->is_value_represented_by_number() && !is_decimal(data_type);
-}
-
 inline bool is_complex_type(const DataTypePtr& data_type) {
     WhichDataType which(data_type);
     return which.is_array() || which.is_map() || which.is_struct();

diff --git a/be/src/vec/data_types/data_type_bitmap.h b/be/src/vec/data_types/data_type_bitmap.h
@@ -77,9 +77,6 @@ class DataTypeBitMap : public IDataType {
     bool should_align_right_in_pretty_formats() const override { return false; }
     bool text_can_contain_only_valid_utf8() const override { return true; }
     bool is_comparable() const override { return false; }
-    bool is_value_represented_by_number() const override { return false; }
-    bool is_value_represented_by_integer() const override { return false; }
-    bool is_value_represented_by_unsigned_integer() const override { return false; }
     // TODO:
     bool is_value_unambiguously_represented_in_contiguous_memory_region() const override {
         return true;

diff --git a/be/src/vec/data_types/data_type_hll.h b/be/src/vec/data_types/data_type_hll.h
@@ -69,9 +69,6 @@ class DataTypeHLL : public IDataType {
     bool should_align_right_in_pretty_formats() const override { return false; }
     bool text_can_contain_only_valid_utf8() const override { return true; }
     bool is_comparable() const override { return false; }
-    bool is_value_represented_by_number() const override { return false; }
-    bool is_value_represented_by_integer() const override { return false; }
-    bool is_value_represented_by_unsigned_integer() const override { return false; }
     // TODO:
     bool is_value_unambiguously_represented_in_contiguous_memory_region() const override {
         return true;

diff --git a/be/src/vec/data_types/data_type_number_base.cpp b/be/src/vec/data_types/data_type_number_base.cpp
@@ -313,16 +313,6 @@ MutableColumnPtr DataTypeNumberBase<T>::create_column() const {
     return ColumnVector<T>::create();
 }
 
-template <typename T>
-bool DataTypeNumberBase<T>::is_value_represented_by_integer() const {
-    return std::is_integral_v<T>;
-}
-
-template <typename T>
-bool DataTypeNumberBase<T>::is_value_represented_by_unsigned_integer() const {
-    return std::is_integral_v<T> && std::is_unsigned_v<T>;
-}
-
 /// Explicit template instantiations - to avoid code bloat in headers.
 template class DataTypeNumberBase<UInt8>;
 template class DataTypeNumberBase<UInt16>;

diff --git a/be/src/vec/data_types/data_type_number_base.h b/be/src/vec/data_types/data_type_number_base.h
@@ -145,8 +145,6 @@ class DataTypeNumberBase : public IDataType {
     bool text_can_contain_only_valid_utf8() const override { return true; }
     bool is_comparable() const override { return true; }
     bool is_value_represented_by_number() const override { return true; }
-    bool is_value_represented_by_integer() const override;
-    bool is_value_represented_by_unsigned_integer() const override;
     bool is_value_unambiguously_represented_in_contiguous_memory_region() const override {
         return true;
     }

diff --git a/be/src/vec/data_types/data_type_quantilestate.h b/be/src/vec/data_types/data_type_quantilestate.h
@@ -72,9 +72,6 @@ class DataTypeQuantileState : public IDataType {
     bool should_align_right_in_pretty_formats() const override { return false; }
     bool text_can_contain_only_valid_utf8() const override { return true; }
     bool is_comparable() const override { return false; }
-    bool is_value_represented_by_number() const override { return false; }
-    bool is_value_represented_by_integer() const override { return false; }
-    bool is_value_represented_by_unsigned_integer() const override { return false; }
     // TODO:
     bool is_value_unambiguously_represented_in_contiguous_memory_region() const override {
         return true;