-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Enhancement] (nereids)implement adminSetTableStatusCommand in nereids (
- Loading branch information
Showing
6 changed files
with
164 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
...c/main/java/org/apache/doris/nereids/trees/plans/commands/AdminSetTableStatusCommand.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.trees.plans.commands; | ||
|
|
||
| import org.apache.doris.catalog.Env; | ||
| import org.apache.doris.catalog.OlapTable.OlapTableState; | ||
| import org.apache.doris.common.AnalysisException; | ||
| import org.apache.doris.common.ErrorCode; | ||
| import org.apache.doris.common.ErrorReport; | ||
| import org.apache.doris.common.UserException; | ||
| import org.apache.doris.common.util.Util; | ||
| import org.apache.doris.mysql.privilege.PrivPredicate; | ||
| import org.apache.doris.nereids.trees.plans.PlanType; | ||
| import org.apache.doris.nereids.trees.plans.commands.info.TableNameInfo; | ||
| import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; | ||
| import org.apache.doris.qe.ConnectContext; | ||
| import org.apache.doris.qe.StmtExecutor; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * AdminSetTableStatusCommand | ||
| */ | ||
| public class AdminSetTableStatusCommand extends Command implements ForwardWithSync { | ||
| public static final String TABLE_STATE = "state"; | ||
| private final TableNameInfo tableNameInfo; | ||
| private final Map<String, String> properties; | ||
| private OlapTableState tableState; | ||
|
|
||
| /** | ||
| * constructor | ||
| */ | ||
| public AdminSetTableStatusCommand(TableNameInfo tableNameInfo, Map<String, String> properties) { | ||
| super(PlanType.ADMIN_SET_TABLE_STATUS_COMMAND); | ||
| this.tableNameInfo = tableNameInfo; | ||
| this.properties = properties; | ||
| } | ||
|
|
||
| @Override | ||
| public void run(ConnectContext ctx, StmtExecutor executor) throws Exception { | ||
| validate(ctx); | ||
| Env.getCurrentEnv().setTableStatusInternal(tableNameInfo.getDb(), tableNameInfo.getTbl(), tableState, false); | ||
| } | ||
|
|
||
| private void validate(ConnectContext ctx) throws UserException { | ||
| // check auth | ||
| if (!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.ADMIN)) { | ||
| ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, "ADMIN"); | ||
| } | ||
|
|
||
| tableNameInfo.analyze(ctx); | ||
| Util.prohibitExternalCatalog(tableNameInfo.getCtl(), this.getClass().getSimpleName()); | ||
|
|
||
| checkProperties(); | ||
| } | ||
|
|
||
| private void checkProperties() throws AnalysisException { | ||
| for (Map.Entry<String, String> entry : properties.entrySet()) { | ||
| String key = entry.getKey(); | ||
| String val = entry.getValue(); | ||
|
|
||
| if (key.equalsIgnoreCase(TABLE_STATE)) { | ||
| try { | ||
| tableState = OlapTableState.valueOf(val.toUpperCase()); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new AnalysisException("Invalid table state: " + val); | ||
| } | ||
| } else { | ||
| throw new AnalysisException("Unsupported property: " + key); | ||
| } | ||
| } | ||
|
|
||
| if (tableState == null) { | ||
| throw new AnalysisException("Should add properties: STATE."); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { | ||
| return visitor.visitAdminSetTableStatusCommand(this, context); | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
regression-test/suites/nereids_p0/ddl/admin/test_nereids_admin_set_tbl_status.groovy
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| suite("test_nereids_admin_set_tbl_status") { | ||
| def tbName1 = "test_nereids_admin_set_tbl_status" | ||
|
|
||
| try { | ||
| sql "DROP TABLE IF EXISTS ${tbName1}" | ||
| sql """ | ||
| CREATE TABLE IF NOT EXISTS ${tbName1} ( | ||
| k1 INT, | ||
| v1 INT, | ||
| v2 INT | ||
| ) | ||
| DUPLICATE KEY (k1) | ||
| DISTRIBUTED BY HASH(k1) BUCKETS 1 properties("replication_num" = "1", "light_schema_change" = "false", "disable_auto_compaction" = "true"); | ||
| """ | ||
|
|
||
| // set table state to ROLLUP | ||
| checkNereidsExecute("ADMIN SET TABLE ${tbName1} STATUS PROPERTIES ('state' = 'rollup');") | ||
| // try alter table comment | ||
| test { | ||
| sql """ ALTER TABLE ${tbName1} MODIFY COMMENT 'test'; """ | ||
| exception "Table[test_nereids_admin_set_tbl_status]'s state(ROLLUP) is not NORMAL. Do not allow doing ALTER ops" | ||
| } | ||
|
|
||
| // set table state to NORMAL | ||
| checkNereidsExecute("ADMIN SET TABLE ${tbName1} STATUS PROPERTIES ('state' = 'normal');") | ||
| // try alter table comment | ||
| sql """ ALTER TABLE ${tbName1} MODIFY COMMENT 'test'; """ | ||
| } finally { | ||
| // drop table | ||
| sql """ DROP TABLE ${tbName1} force""" | ||
| } | ||
| } |