Skip to content

Commit

Permalink
1
Browse files Browse the repository at this point in the history
  • Loading branch information
Yukang-Lian committed Nov 27, 2024
1 parent c770bc8 commit 899ea90
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion be/src/olap/tablet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1727,15 +1727,21 @@ Status Tablet::prepare_compaction_and_calculate_permits(
}

if (!res.ok()) {
tablet->set_last_cumu_compaction_failure_time(UnixMillis());
permits = 0;
if (!res.is<CUMULATIVE_NO_SUITABLE_VERSION>()) {
tablet->set_last_cumu_compaction_failure_time(UnixMillis());
DorisMetrics::instance()->cumulative_compaction_request_failed->increment(1);
return Status::InternalError("prepare cumulative compaction with err: {}", res);
}
// return OK if OLAP_ERR_CUMULATIVE_NO_SUITABLE_VERSION, so that we don't need to
// print too much useless logs.
// And because we set permits to 0, so even if we return OK here, nothing will be done.
LOG_INFO(
"cumulative compaction meet delete rowset, increase cumu point without other "
"operation.")
.tag("tablet id:", tablet->tablet_id())
.tag("after cumulative compaction, cumu point:",
tablet->cumulative_layer_point());
return Status::OK();
}
} else if (compaction_type == CompactionType::BASE_COMPACTION) {
Expand Down

0 comments on commit 899ea90

Please sign in to comment.