-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
- Loading branch information
1 parent
4100a75
commit 49d1671
Showing
8 changed files
with
137 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
fe/fe-core/src/main/java/org/apache/doris/qe/LimitUtils.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.qe; | ||
|
|
||
| import org.apache.doris.common.Status; | ||
| import org.apache.doris.thrift.TStatusCode; | ||
|
|
||
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; | ||
|
|
||
| import java.util.function.Consumer; | ||
|
|
||
| /** | ||
| * This is a utility class for limit related operations. | ||
| * Because current there are 2 places need to check limit rows, so put the logic here for unification. | ||
| * - Coordinator.getNext(); | ||
| * - QueryProcessor.getNext(); | ||
| */ | ||
| public class LimitUtils { | ||
| private static final Logger LOG = LogManager.getLogger(LimitUtils.class); | ||
| private static final Status LIMIT_REACH_STATUS = new Status(TStatusCode.LIMIT_REACH, "query reach limit"); | ||
|
|
||
| // if reached limit rows, cancel this query immediately | ||
| // to avoid BE from reading more data. | ||
| public static boolean cancelIfReachLimit(RowBatch resultBatch, long limitRows, long numReceivedRows, | ||
| Consumer<Status> cancelFunc) { | ||
| boolean reachedLimit = false; | ||
| if (limitRows > 0 && numReceivedRows >= limitRows) { | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("reach limit rows: {}, received rows: {}, cancel query", limitRows, numReceivedRows); | ||
| } | ||
| cancelFunc.accept(LIMIT_REACH_STATUS); | ||
| // set this | ||
| resultBatch.setEos(true); | ||
| reachedLimit = true; | ||
| } | ||
| return reachedLimit; | ||
| } | ||
| } |
59 changes: 59 additions & 0 deletions
59
fe/fe-core/src/test/java/org/apache/doris/qe/LimitUtilsTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.qe; | ||
|
|
||
|
|
||
| import org.apache.doris.common.Status; | ||
|
|
||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.function.Consumer; | ||
|
|
||
| public class LimitUtilsTest { | ||
|
|
||
| private static int res = 0; | ||
|
|
||
| @Test | ||
| public void testUpperBound() { | ||
| Consumer<Status> cancelFunc = batch -> res = 666; | ||
| RowBatch rowBatch = new RowBatch(); | ||
| rowBatch.setEos(false); | ||
| // - no limit | ||
| Assert.assertFalse(LimitUtils.cancelIfReachLimit(rowBatch, 0, 10, cancelFunc)); | ||
| Assert.assertFalse(rowBatch.isEos()); | ||
| Assert.assertEquals(0, res); | ||
|
|
||
| // - not reach limit | ||
| Assert.assertFalse(LimitUtils.cancelIfReachLimit(rowBatch, 10, 1, cancelFunc)); | ||
| Assert.assertFalse(rowBatch.isEos()); | ||
| Assert.assertEquals(0, res); | ||
|
|
||
| // - reach limit | ||
| Assert.assertTrue(LimitUtils.cancelIfReachLimit(rowBatch, 10, 10, cancelFunc)); | ||
| Assert.assertTrue(rowBatch.isEos()); | ||
| Assert.assertEquals(666, res); | ||
|
|
||
| // - reach limit | ||
| res = 0; | ||
| rowBatch.setEos(false); | ||
| Assert.assertTrue(LimitUtils.cancelIfReachLimit(rowBatch, 10, 100, cancelFunc)); | ||
| Assert.assertTrue(rowBatch.isEos()); | ||
| Assert.assertEquals(666, res); | ||
| } | ||
| } |