-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-16900][api] fix when the copied workflow, the logical node switch loses the flow relationship #16911
Conversation
...rc/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java
Show resolved
Hide resolved
...rc/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
没有处理掉,工作流还是不能复制逻辑节点的关联关系 |
Please using english to describe. |
Workflow still cannot copy the association relationship of logical nodes |
@SbloodyS |
You can run |
@SbloodyS done, Can you check it again please. |
@SbloodyS @ruanwenjun PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nit.
...rc/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
…h loses the flow relationship
Co-authored-by: Wenjun Ruan <[email protected]>
good better best |
@caishunfeng PTAL |
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Awesome work, congrats on your first merged pull request! |
Merged into dev, this will be released at 3.3.0, thanks for your PR. |
#16934 When copying workflows containing switch nodes, if created in different orders, the associated relationships will also be lost |
…h loses the flow relationship
Purpose of the pull request
Fix #16900
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md