Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16900][api] fix when the copied workflow, the logical node switch loses the flow relationship #16911

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

llllkid
Copy link
Contributor

@llllkid llllkid commented Dec 23, 2024

…h loses the flow relationship

Purpose of the pull request

Fix #16900

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun changed the title [fix-16900][api] fix when the copied workflow, the logical node switc… [fix-16900][api] fix when the copied workflow, the logical node switch loses the flow relationship Dec 23, 2024
@ruanwenjun ruanwenjun added the bug Something isn't working label Dec 23, 2024
@llllkid llllkid requested a review from ruanwenjun December 23, 2024 09:38
@llllkid llllkid changed the title [fix-16900][api] fix when the copied workflow, the logical node switch loses the flow relationship [Fix-16900][api] fix when the copied workflow, the logical node switch loses the flow relationship Dec 24, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Dec 24, 2024
@SbloodyS SbloodyS added the first time contributor First-time contributor label Dec 24, 2024
@llllkid llllkid requested a review from SbloodyS December 24, 2024 09:04
@HEEKDragonOne
Copy link

没有处理掉,工作流还是不能复制逻辑节点的关联关系

@github-actions github-actions bot added the test label Dec 24, 2024
@SbloodyS
Copy link
Member

没有处理掉,工作流还是不能复制逻辑节点的关联关系

Please using english to describe.

@HEEKDragonOne
Copy link

没有处理掉,工作流还是不能复制逻辑节点的关联关系

Please using english to describe.

Workflow still cannot copy the association relationship of logical nodes

@llllkid
Copy link
Contributor Author

llllkid commented Dec 25, 2024

没有处理掉,工作流还是不能复制逻辑节点的关联关系

Please using english to describe.

Workflow still cannot copy the association relationship of logical nodes

Hi,what is the version of your dolphinScheduler?
I fixed in the dev branch, I will try to upload a gif to prove that the fix was useful.
If there is nothing wrong with the gif, then you can see the results after the fix.
switch-gif-2

@HEEKDragonOne
Copy link

没有处理掉,工作流还是不能复制逻辑节点的关联关系

Please using english to describe.

Workflow still cannot copy the association relationship of logical nodes

Hi,what is the version of your dolphinScheduler? I fixed in the dev branch, I will try to upload a gif to prove that the fix was useful. If there is nothing wrong with the gif, then you can see the results after the fix. switch-gif-2 switch-gif-2

ok

@llllkid
Copy link
Contributor Author

llllkid commented Dec 26, 2024

@SbloodyS
hi,this is my first time contribut。
i see the style check did’t pass, should I change the code and commit it again?

@SbloodyS
Copy link
Member

You can run mvn spotless:apply to fix these violations. @JackIllkid

@llllkid
Copy link
Contributor Author

llllkid commented Dec 26, 2024

您可以运行mvn spotless:apply来修复这些违规行为。@JackIllkid

@SbloodyS done, Can you check it again please.

@llllkid
Copy link
Contributor Author

llllkid commented Dec 27, 2024

@SbloodyS @ruanwenjun PTAL

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit.

@llllkid
Copy link
Contributor Author

llllkid commented Dec 27, 2024

LGTM, one nit.

good better best

@llllkid
Copy link
Contributor Author

llllkid commented Dec 27, 2024

@caishunfeng PTAL

ruanwenjun
ruanwenjun previously approved these changes Dec 27, 2024
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@ruanwenjun ruanwenjun merged commit adee537 into apache:dev Dec 30, 2024
69 of 70 checks passed
Copy link

boring-cyborg bot commented Dec 30, 2024

Awesome work, congrats on your first merged pull request!

@ruanwenjun
Copy link
Member

ruanwenjun commented Dec 30, 2024

Merged into dev, this will be released at 3.3.0, thanks for your PR.

@HEEKDragonOne
Copy link

#16934 When copying workflows containing switch nodes, if created in different orders, the associated relationships will also be lost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working first time contributor First-time contributor priority:high test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] In the copied workflow, the logical node switch loses the flow relationship
5 participants