Apply suggestions from code review

Co-authored-by: Wenjun Ruan <[email protected]>
apache · Dec 27, 2024 · d335f78 · d335f78
1 parent 63e9ed4
commit d335f78
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/...main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java b/...main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java
@@ -2133,11 +2133,9 @@ protected void doBatchOperateWorkflowDefinition(User loginUser,
                                         "Switch task params: " + taskParams + " is invalid.");
                             }
                             SwitchParameters.SwitchResult switchResult = switchParameters.getSwitchResult();
-                            List<SwitchResultVo> dependTaskList = switchResult.getDependTaskList();
-                            dependTaskList.forEach(switchResultVo -> {
+                            switchResult.getDependTaskList().forEach(switchResultVo -> {
                                 switchResultVo.setNextNode(taskCodeMap.get(switchResultVo.getNextNode()));
                             });
-                            switchResult.setDependTaskList(dependTaskList);
                             if (switchResult.getNextNode() != null) {
                                 switchResult.setNextNode(
                                         taskCodeMap.get(switchResult.getNextNode()));