Skip to content

Run cargo-fmt on all of datafusion-functions #9390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 28, 2024

Which issue does this PR close?

Closes #9281

Rationale for this change

The way we were defining modules in datafusion-functions meant that rustfmt was not running on them

What changes are included in this PR?

This applies the fix in #9367 to all the packages in the datafusion-functions crate

Are these changes tested?

covered by CI

Are there any user-facing changes?

No

"encoding_expressions",
"Hex and binary `encode` and `decode` functions."
);
/// Encoding expressions.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual change of this PR. The rest of the PR is the result of running cargo fmt and checking it in

Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb
Copy link
Contributor Author

alamb commented Feb 28, 2024

I am going to merge this one in as it will cause conflicts (including logical conflicts) as we port the code to datafusion-functions

@alamb alamb merged commit cf69d38 into apache:main Feb 28, 2024
@alamb
Copy link
Contributor Author

alamb commented Feb 28, 2024

Thanks for the review @Jefffrey

@alamb alamb deleted the alamb/format_all branch February 28, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo-fmt cannot format modules declared inside macros
2 participants