implement string_to_array #7577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
reviewed
Sep 16, 2023
There was a problem hiding this comment.
Thank you @casperhart
It is neat to see something like split be added to DataFusion
Yes, the addition of a new sql function is a user facing change. However, I'm not sure how to update the docs, but happy to do so if you can point me in the right direction.
The docs to update are in https://github.com/apache/arrow-datafusion/blob/main/docs/source/user-guide/sql/scalar_functions.md#array-functions
cc @jayzhan211 and @izveigor do either if you have some time to review this PR?
jayzhan211
reviewed
Sep 16, 2023
alamb
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Thank you @casperhart and @jayzhan211 for the reivew. I think this PR is looking very nice 👨🍳 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7555
What changes are included in this PR?
string_to_arraysimilar to postgres. Functionality is based off the function with the same name here: https://www.postgresql.org/docs/9.1/functions-array.htmlAre these changes tested?
I've included tests in both
tests/sql/expr.rsandfunctions.slt. This duplication may not be necessary, so I'd be happy to remove one.Are there any user-facing changes?
Yes, the addition of a new sql function is a user facing change. However, I'm not sure how to update the docs, but happy to do so if you can point me in the right direction.