Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor fix]: Remove unused duplicate file_type.rs #7478

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Sep 5, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

There are two file_type.rs in common/src/ and common/src/file_options. They are almost the same and the former seems not to be used.
To avoid running unnecessary tests and maintaining unused file, let's remove unused one.

What changes are included in this PR?

Removed common/src/file_type.rs.

Are these changes tested?

Done by CI.

Are there any user-facing changes?

No.

@sarutak sarutak changed the title [minor fix] Remove unused duplicate file_type.rs [minor fix]: Remove unused duplicate file_type.rs Sep 5, 2023
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @sarutak

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the file is not even included in module tree.

@alamb
Copy link
Contributor

alamb commented Sep 5, 2023

Thank you @sarutak

@alamb alamb merged commit 03bbc0d into apache:main Sep 5, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants