minor: do not fail analyzer if subquery plan contains extension #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
alamb
approved these changes
Sep 5, 2023
| @@ -338,3 +339,57 @@ fn check_mixed_out_refer_in_window(window: &Window) -> Result<()> { | |||
| Ok(()) | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
I recommend putting this test somewhere in https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/user_defined (mostly so it is easier to find and to ensure everything is working as expected)
I think you may be able to reuse the dummy user defined code there
There was a problem hiding this comment.
Great suggestion. I plan to cover this case in datafusion/core/tests/user_defined/user_defined_plan.rs. But since the previous TopK is based on optimizer, I may need to add another extension plan and an analyzer rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
If some analyze rule inserts extension plan, the post-analyze check will fail.
What changes are included in this PR?
It looks acceptable for an analyzer rule to do so and can simply "ignore" extension plan node, e.g., the outermost node can either be
[Projection, Filter, Window, Aggregate, Join], or an extension nodeAre these changes tested?
n/a
Are there any user-facing changes?
n/a