feat: Add linear regression aggregate functions #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
2010YOUY01
changed the title
|
Thank you @2010YOUY01 -- this looks awesome. I plan to review it carefully tomorrow |
alamb
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
This looks great @2010YOUY01 -- thank you. I reviewed it carefully and I think the structure and comments are very nice and the documentation is 👌
Thank you for the contribution
| Ok(ScalarValue::Float64(None)) | ||
| } else { | ||
| Ok(ScalarValue::Float64(Some(cov_pop_x_y / var_pop_x))) | ||
| match self.regr_type { |
2010YOUY01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NA
Rationale for this change
A previous PR first implemented
regr_slope(y, x)linear regression aggregate function #7135This PR wants to extend the previous one to implement all PostgreSQL's linear regression aggregate functions like
regr_intercept(y, x)https://www.postgresql.org/docs/9.4/functions-aggregate.html
What changes are included in this PR?
Extend
RegrAccumulatorto support otherregr_*(y, x)aggregate functionsAre these changes tested?
All end-to-end tests have the same result compared to PostgreSQL
Are there any user-facing changes?
No