Minor: Add Accumulator::return_type and StateFieldsArgs::return_type to help with upgrade to 48
#16112
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
alamb
changed the title
Accumulator::return_type to help with transitionAccumulator::return_type and StateFieldsArgs::return_type to help with upgrade to 48
timsaucer
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupsAccumulatorfor Avg duration #15748Which issue does this PR close?
Rationale for this change
#15911 from @timsaucer added
Accumulator::return_fieldto make it more general, but that requires changing all call sites to refer toreturn_field.data_type()In DataFusion 47:
on
main:To help with the migration, I added a
return_type()method toAccumulatorArgsAfter this PR (the code looks much closer to DataFusion 47):
I will add similar functions to the
WindowUDFFieldArgsandScalarFunctionArgsWhat changes are included in this PR?
return_type()method toAccumulatorArgsAre these changes tested?
By exsiting CI tests
Are there any user-facing changes?