Semver-checks for all crate on merge and push #16078
Conversation
github-actions
bot
added
the
development-process
|
|
logan-keede
changed the title
|
cc @crepererum |
|
I unfortunately do not have the time currently to do a proper review of this PR. Hopefully I'll have time in June if it's not reviewed by then. |
| - name: Run semver-check datasource | ||
| run: cargo semver-checks check-release -p datafusion-datasource -p datafusion-datasource-avro -p datafusion-datasource-csv -p datafusion-datasource-json -p datafusion-datasource-parquet | ||
| continue-on-error: true | ||
| - name: Run semver-check common | ||
| run: cargo semver-checks check-release -p datafusion-common -p datafusion-common-runtime | ||
| continue-on-error: true | ||
| - name: Run semver-check catalog | ||
| run: cargo semver-checks check-release -p datafusion-catalog -p datafusion-catalog-listing | ||
| continue-on-error: true | ||
| - name: Run semver-check execution | ||
| run: cargo semver-checks check-release -p datafusion-execution -p datafusion-session | ||
| continue-on-error: true | ||
| - name: Run semver-check expr | ||
| run: cargo semver-checks check-release -p datafusion-expr -p datafusion-expr-common -p datafusion-physical-expr | ||
| continue-on-error: true | ||
| - name : Run semver-check functions | ||
| run: cargo semver-checks check-release -p datafusion-functions -p datafusion-functions-aggregate -p datafusion-functions-aggregate-common -p datafusion-functions-nested -p datafusion-functions-table -p datafusion-functions-window -p datafusion-functions-window-common | ||
| continue-on-error: true |
There was a problem hiding this comment.
I wonder if we can somehow automate this listing? Otherwise we will likely never update this list when we add new crates.
| continue-on-error: true | ||
|
|
||
|
|
||
| semver-checks-2: |
There was a problem hiding this comment.
why are there multiple jobs?
There was a problem hiding this comment.
because a single job runs out of disk space.
|
The check also fails currently but is marked as "green". I think this way it has little value, because nobody will likely check the logs. |
I think that is the only way to do it, otherwise it will always show red till you change the Version of the crate according to SemVer, which is not possible for each PR or merge. It is more of a reviewer convenience thing to spot API changes IMO. also it is more convenient to have all the API changes in job then to wait because it failed in one crate before. |
|
I think the job should compare against current |
Which issue does this PR close?
cargo-semver-checks#15408cargo semver-checksfor release testing #13665Rationale for this change
Detect accidental breaking changes.
What changes are included in this PR?
A github workflow, that uses
cargo semver-checksfor all crates. divided into three parts because 1 job goes on for too long + crashes before completion(can probably be fixed by emptying/deleting cache in the middle.)Are these changes tested?
On local branch by CI.
Are there any user-facing changes?
NO.