Make Diagnostic easy/convinient to attach by using macro and avoiding map_err
#15796
Conversation
datafusion/sql/src/expr/function.rs
Outdated
| Diagnostic::new_error(format!("Invalid function '{name}'"), span); | ||
| diagnostic | ||
| .add_note(format!("Possible function '{}'", suggested_func_name), None); | ||
| plan_err!("Invalid function '{name}'.\nDid you mean '{suggested_func_name}'?"; diag=diagnostic) |
There was a problem hiding this comment.
I had to use ; which is a bit weird, but works, is this acceptable @comphead?
There was a problem hiding this comment.
that would be not very obvious it is true.
|
@logan-keede please run the planner tests to check if this change affects planner performance, we got some experience in the past #7522 |
cargo bench --bench sql_plannerbench.txt UPD: I ran them again a couple of times and they seem to be giving variable results. This pattern seems to be persisting over main branch too. so, it probably should not be a blocker. |
…ng `map_err` (apache#15796) * First Step * Final Step? * Homogenisation
Which issue does this PR close?
Originally posted by @comphead in #15680 (comment)
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?