Skip to content

chore: update clickbench #15574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

chore: update clickbench #15574

merged 2 commits into from
Apr 4, 2025

Conversation

chenkovsky
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

remove ::INT::DATE in clickbench.

I have two questions

  1. should we make sure clickbench.slt in sync with queries.sql in clickbench directory ? currently they are a bit different.
  2. should we remove cast in SELECT MIN("EventDate"::INT::DATE), MAX("EventDate"::INT::DATE) FROM hits;

Are these changes tested?

No

Are there any user-facing changes?

No

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs the queries both on clickbench / clickbench_partitioned for me

@Dandandan
Copy link
Contributor

Dandandan commented Apr 4, 2025

should we make sure clickbench.slt in sync with queries.sql in clickbench directory ? currently they are a bit different.

Yes that makes sense, could you do that as well?

should we remove cast in SELECT MIN("EventDate"::INT::DATE), MAX("EventDate"::INT::DATE) FROM hits;

Yes, I checked, it isn't there in e.g. https://github.com/ClickHouse/ClickBench/blob/main/duckdb-parquet/queries.sql as well.

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Apr 4, 2025
@alamb
Copy link
Contributor

alamb commented Apr 4, 2025

I am tracking our next run of ClickBench in #14587

Yes, I checked, it isn't there in e.g. https://github.com/ClickHouse/ClickBench/blob/main/duckdb-parquet/queries.sql as well.

I have also tried to collect the things we'll have to do in the next run on that ticket

@comphead comphead merged commit 1a39175 into apache:main Apr 4, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ClickBench queries to avoid ::INT::DATE casting
5 participants