Skip to content

Run audit CI check on all pushes to main #15572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 3, 2025

Which issue does this PR close?

Rationale for this change

We should be running the AUDIT check on all PRs to main so we don't see it for the first time on unrelated PRs

What changes are included in this PR?

Add additional trigger for audit CI job on pushes to main

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Apr 3, 2025
@alamb
Copy link
Contributor Author

alamb commented Apr 4, 2025

🤖 ./gh_compare_branch.sh Benchmark Script Running
Linux aal-dev 6.8.0-1016-gcp #18-Ubuntu SMP Fri Oct 4 22:16:29 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/run_audit to 0b061be using Benchmarks: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@alamb
Copy link
Contributor Author

alamb commented Apr 4, 2025

🤖: Benchmark completed

Details

Comparing HEAD and alamb_run_audit
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query        ┃       HEAD ┃ alamb_run_audit ┃    Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 0     │  2043.69ms │       2005.19ms │ no change │
│ QQuery 1     │   685.14ms │        698.97ms │ no change │
│ QQuery 2     │  1434.62ms │       1453.63ms │ no change │
│ QQuery 3     │   712.95ms │        720.18ms │ no change │
│ QQuery 4     │  1490.96ms │       1491.47ms │ no change │
│ QQuery 5     │ 16989.12ms │      17116.63ms │ no change │
│ QQuery 6     │  6580.71ms │       6645.22ms │ no change │
└──────────────┴────────────┴─────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary              ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)              │ 29937.19ms │
│ Total Time (alamb_run_audit)   │ 30131.30ms │
│ Average Time (HEAD)            │  4276.74ms │
│ Average Time (alamb_run_audit) │  4304.47ms │
│ Queries Faster                 │          0 │
│ Queries Slower                 │          0 │
│ Queries with No Change         │          7 │
└────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃       HEAD ┃ alamb_run_audit ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │     1.97ms │          2.28ms │  1.16x slower │
│ QQuery 1     │    35.60ms │         34.69ms │     no change │
│ QQuery 2     │    91.11ms │         91.12ms │     no change │
│ QQuery 3     │   105.26ms │        103.43ms │     no change │
│ QQuery 4     │   822.73ms │        746.59ms │ +1.10x faster │
│ QQuery 5     │   873.54ms │        859.47ms │     no change │
│ QQuery 6     │    33.58ms │         34.09ms │     no change │
│ QQuery 7     │    39.57ms │         40.08ms │     no change │
│ QQuery 8     │   966.45ms │        961.07ms │     no change │
│ QQuery 9     │  1259.08ms │       1240.50ms │     no change │
│ QQuery 10    │   275.04ms │        263.91ms │     no change │
│ QQuery 11    │   304.16ms │        310.92ms │     no change │
│ QQuery 12    │   983.26ms │        962.09ms │     no change │
│ QQuery 13    │  1422.20ms │       1453.85ms │     no change │
│ QQuery 14    │   883.19ms │        885.65ms │     no change │
│ QQuery 15    │  1086.87ms │       1074.85ms │     no change │
│ QQuery 16    │  1784.18ms │       1812.66ms │     no change │
│ QQuery 17    │  1667.28ms │       1653.21ms │     no change │
│ QQuery 18    │  3177.44ms │       3174.13ms │     no change │
│ QQuery 19    │    86.35ms │         86.23ms │     no change │
│ QQuery 20    │  1153.20ms │       1134.69ms │     no change │
│ QQuery 21    │  1364.11ms │       1399.94ms │     no change │
│ QQuery 22    │  2494.81ms │       2485.57ms │     no change │
│ QQuery 23    │  8655.12ms │       8649.43ms │     no change │
│ QQuery 24    │   484.40ms │        487.64ms │     no change │
│ QQuery 25    │   399.46ms │        390.43ms │     no change │
│ QQuery 26    │   548.36ms │        549.28ms │     no change │
│ QQuery 27    │  1707.05ms │       1715.99ms │     no change │
│ QQuery 28    │ 12847.02ms │      12902.25ms │     no change │
│ QQuery 29    │   537.66ms │        539.92ms │     no change │
│ QQuery 30    │   859.14ms │        853.98ms │     no change │
│ QQuery 31    │   912.61ms │        903.32ms │     no change │
│ QQuery 32    │  2760.73ms │       2809.73ms │     no change │
│ QQuery 33    │  3462.10ms │       3467.83ms │     no change │
│ QQuery 34    │  3473.89ms │       3447.05ms │     no change │
│ QQuery 35    │  1346.15ms │       1350.80ms │     no change │
│ QQuery 36    │   223.16ms │        223.69ms │     no change │
│ QQuery 37    │    93.38ms │         89.49ms │     no change │
│ QQuery 38    │   126.26ms │        126.32ms │     no change │
│ QQuery 39    │   434.98ms │        411.58ms │ +1.06x faster │
│ QQuery 40    │    48.47ms │         51.76ms │  1.07x slower │
│ QQuery 41    │    43.89ms │         44.20ms │     no change │
│ QQuery 42    │    54.08ms │         54.30ms │     no change │
└──────────────┴────────────┴─────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary              ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)              │ 59928.86ms │
│ Total Time (alamb_run_audit)   │ 59880.00ms │
│ Average Time (HEAD)            │  1393.69ms │
│ Average Time (alamb_run_audit) │  1392.56ms │
│ Queries Faster                 │          2 │
│ Queries Slower                 │          2 │
│ Queries with No Change         │         39 │
└────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃     HEAD ┃ alamb_run_audit ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 120.92ms │        121.40ms │     no change │
│ QQuery 2     │  24.62ms │         24.78ms │     no change │
│ QQuery 3     │  35.67ms │         36.10ms │     no change │
│ QQuery 4     │  21.63ms │         21.46ms │     no change │
│ QQuery 5     │  56.32ms │         56.88ms │     no change │
│ QQuery 6     │   8.13ms │          8.33ms │     no change │
│ QQuery 7     │ 106.57ms │        104.35ms │     no change │
│ QQuery 8     │  26.68ms │         26.33ms │     no change │
│ QQuery 9     │  62.28ms │         64.35ms │     no change │
│ QQuery 10    │  61.00ms │         59.34ms │     no change │
│ QQuery 11    │  13.39ms │         12.98ms │     no change │
│ QQuery 12    │  39.80ms │         36.87ms │ +1.08x faster │
│ QQuery 13    │  29.82ms │         30.21ms │     no change │
│ QQuery 14    │  10.08ms │          9.87ms │     no change │
│ QQuery 15    │  25.59ms │         25.80ms │     no change │
│ QQuery 16    │  22.78ms │         22.78ms │     no change │
│ QQuery 17    │  96.41ms │         98.01ms │     no change │
│ QQuery 18    │ 260.12ms │        247.75ms │     no change │
│ QQuery 19    │  32.03ms │         28.48ms │ +1.12x faster │
│ QQuery 20    │  41.26ms │         39.90ms │     no change │
│ QQuery 21    │ 183.12ms │        182.85ms │     no change │
│ QQuery 22    │  16.98ms │         18.19ms │  1.07x slower │
└──────────────┴──────────┴─────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary              ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)              │ 1295.20ms │
│ Total Time (alamb_run_audit)   │ 1277.01ms │
│ Average Time (HEAD)            │   58.87ms │
│ Average Time (alamb_run_audit) │   58.05ms │
│ Queries Faster                 │         2 │
│ Queries Slower                 │         1 │
│ Queries with No Change         │        19 │
└────────────────────────────────┴───────────┘

@alamb
Copy link
Contributor Author

alamb commented Apr 4, 2025

I ran the benchmark thing to test the benchmarking script, I don't expect this PR to change peformance

I am going to merge this PR even though we haven't fixed #15571 because otherwise the failure only affects some PRs unfairly. Let's get it fixed for real

@alamb alamb merged commit 5a335b8 into apache:main Apr 4, 2025
27 checks passed
@alamb alamb deleted the alamb/run_audit branch April 4, 2025 17:59
nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants