Add CatalogProvider and SchemaProvider to FFI Crate #15280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2025
alamb
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
The basic idea looks good to me -- I didn't go through this one carefully but I skimmed it and what I saw looks good
My only real suggestion is to try and add a more end to end example in https://github.com/apache/datafusion/tree/main/datafusion-examples/examples/ffi so that it is more likely this interface works when it is hooked up outside unit tests
|
Thank you @timsaucer |
|
Oh, good point. Added in latest push. |
|
🎉 |
This was referenced Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR expands the interfaces available via FFI to include Catalogs and Schemas (catalog schema, not arrow schema).
What changes are included in this PR?
Adds FFI variants of CatalogProvider and SchemaProvider
Are these changes tested?
Unit tests included. Coverage is shown here:
Are there any user-facing changes?
None