feat: Native support utf8view for regex string operators #15275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
6 tasks
alamb
changed the title
alamb
approved these changes
Mar 17, 2025
| @@ -1177,26 +1177,6 @@ pub fn string_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<DataT | |||
| } | |||
| } | |||
|
|
|||
| /// This will be deprecated when binary operators native support | |||
| @@ -1100,7 +1100,7 @@ EXPLAIN SELECT | |||
| FROM test; | |||
| ---- | |||
| logical_plan | |||
| 01)Projection: CAST(test.column1_utf8view AS Utf8) LIKE Utf8("%an%") AS c1 | |||
| 01)Projection: test.column1_utf8view ~ Utf8View("an") AS c1 | |||
|
Thanks again @zhuqi-lucas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#15096
Rationale for this change
feat: Native support utf8view for binary operator
Because upstream arrow-rs already support utf8view for the remaining function for ut8view such as regex_match, details:
apache/arrow-rs#6717
What changes are included in this PR?
feat: Native support utf8view for binary operator
Because upstream arrow-rs already support utf8view for the remaining function for ut8view such as regex_match.
Are these changes tested?
Yes
Are there any user-facing changes?
feat: Native support utf8view for binary operator