Implement tree rendering for SortPreservingMergeExec
#15140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
approved these changes
Mar 11, 2025
|
Thank you for making this happen. I have a suggestion: I think the only field needed inside
|
irenjj
reviewed
Mar 11, 2025
alamb
reviewed
Mar 11, 2025
There was a problem hiding this comment.
Thanks @Standing-Man -- this is looking good. I think @irenjj 's suggestions are worth doing and then we can get this PR merged in
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Standing-Man
force-pushed
the
SortPreservingMergeExec
branch
from
ac3edad to
4d1c51b
Compare
|
Hi @2010YOUY01, @alamb, @irenjj and @Weijun-H, Thank you for your suggestions. I have implemented them in the new commit. |
irenjj
reviewed
Mar 12, 2025
|
Thank you @Standing-Man and @2010YOUY01 and @Weijun-H |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
SortPreservingMergeExec#15139 and Part of [EPIC] CompleteSQL EXPLAINTree Rendering #14914.Rationale for this change
What changes are included in this PR?
Implement tree rendering for
SortPreservingMergeExecAre these changes tested?
Yes
Are there any user-facing changes?