Implement tree explain for RepartitionExec and WorkTableExec
#15137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
2010YOUY01
reviewed
Mar 11, 2025
There was a problem hiding this comment.
Thank you again for the great PR.
I have some suggestions regarding RepartitionExec: Both input and output partition count are required, IIRC it's possible some RepartitionExec takes 2 input partitions and do round-robin to yield 3 output partitions.
Also, I don't fully understand this WorkTableExec, do you have any idea to give this name field a more descriptive name, perhaps recursive_relation_name?
alamb
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Thank you @Standing-Man and @2010YOUY01
I merged up from main to resolve a conflict with this PR
I think we are getting close...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RepartitionExecandWorkTableExec#15097 and part of [EPIC] CompleteSQL EXPLAINTree Rendering #14914.Rationale for this change
What changes are included in this PR?
Implement tree explain for
RepartitionExecandWorkTableExec.Are these changes tested?
Yes
Are there any user-facing changes?