Do not display logical_plan win explain tree mode 🧹
#15132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Mar 10, 2025
| @@ -1727,7 +1727,10 @@ impl DefaultPhysicalPlanner { | |||
| let config = &session_state.config_options().explain; | |||
| let explain_format = DisplayFormatType::from_str(&config.format)?; | |||
|
|
|||
| if !config.physical_plan_only { | |||
| let skip_logical_plan = config.physical_plan_only | |||
There was a problem hiding this comment.
this is the code change
github-actions
bot
added
core
This was referenced Mar 10, 2025
xudong963
approved these changes
Mar 11, 2025
|
Thanks @xudong963 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
treeexplain format #15020SQL EXPLAINTree Rendering #14914Rationale for this change
See #15020
I mostly want to focus our PRs for
treemode and keep the slt diff downWhat changes are included in this PR?
Do not print logical plans in explain
treemodeAre these changes tested?
yes
Are there any user-facing changes?