Implement tree explain for AggregateExec #15103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
reviewed
Mar 11, 2025
Comment on lines
817
to
822
| let e = e.to_string(); | ||
| if &e != alias { | ||
| format!("{e} as {alias}") | ||
| } else { | ||
| e | ||
| } |
There was a problem hiding this comment.
Could you extract this logic? It would greatly increase readability.
There was a problem hiding this comment.
Thank you @Weijun-H -- amazing suggestion :)
and already updated
|
I also tested that these tests pass on main after merging up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
treeexplain forAggregateExec#15024SQL EXPLAINTree Rendering #14914What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No