Skip to content

TESTING (NOT FOR MERGE) Test arrow/parquet 54.2.1 #14915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 27, 2025

Which issue does this PR close?

Rationale for this change

I am using this PR to verify the 54.2.1 arrow hotfix

What changes are included in this PR?

Without this PR, the following command fails:

andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo install --path datafusion-cli/
  Installing datafusion-cli v45.0.0 (/Users/andrewlamb/Software/datafusion/datafusion-cli)
    Updating crates.io index
...

   Compiling hyper-rustls v0.24.2
error[E0034]: multiple applicable items in scope
   --> /Users/andrewlamb/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/arrow-arith-54.2.0/src/temporal.rs:92:36
    |
92  |         DatePart::Quarter => |d| d.quarter() as i32,
    |                                    ^^^^^^^ multiple `quarter` found
    |
note: candidate #1 is defined in the trait `ChronoDateExt`
   --> /Users/andrewlamb/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/arrow-arith-54.2.0/src/temporal.rs:638:5
    |
638 |     fn quarter(&self) -> u32;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
note: candidate #2 is defined in the trait `Datelike`
   --> /Users/andrewlamb/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/chrono-0.4.40/src/traits.rs:47:5
    |
47  |     fn quarter(&self) -> u32 {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^
help: disambiguate the method for candidate #1
    |
92  |         DatePart::Quarter => |d| ChronoDateExt::quarter(&d) as i32,
    |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~
help: disambiguate the method for candidate #2
    |
92  |         DatePart::Quarter => |d| Datelike::quarter(&d) as i32,
    |                                  ~~~~~~~~~~~~~~~~~~~~~

   Compiling apache-avro v0.17.0
For more information about this error, try `rustc --explain E0034`.

With this PR, building succeeds:

andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo install --path datafusion-cli/
...

Are these changes tested?

Are there any user-facing changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant