chore: Attach Diagnostic to "function x does not exist" error #14849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliaperantoni
approved these changes
Feb 25, 2025
datafusion/sql/src/expr/function.rs
Outdated
| let mut diagnostic = | ||
| Diagnostic::new_error(format!("Invalid function '{name}'"), span); | ||
| diagnostic.add_note( | ||
| format!("possible function {}", suggested_func_name), |
There was a problem hiding this comment.
Perhaps this should be uppercase? Considering it's a message seen by an end user and not a programmatically consumed string.
There was a problem hiding this comment.
delivered in 8441bb8
alamb
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Thanks @onlyjackfrost and @eliaperantoni
I think @eliaperantoni 's suggestion about message is a good one, but otherwise this one looks good to go to me
|
🚀 -- thanks again @onlyjackfrost and @eliaperantoni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Diagnosticto "function x does not exist" error #14430Rationale for this change
well explained in the issue.
What changes are included in this PR?
This PR attaches
Diagnosticwith the "function x does not exist" error.Get the span of function from sql-parser, then attach to Diagnostic after transformation.
Are these changes tested?
yes, unit test was added.