Skip to content

feat: implement contextualized ObjectStore #14805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

waynr
Copy link

@waynr waynr commented Feb 21, 2025

  • chore(temporary): patch objectstore with local path
  • feat: implement ContextualizedObjectStore that passes along session state via GetOptions
  • chore: update temporary object_store patch rev

Which issue does this PR close?

Rationale for this change

See #14804

What changes are included in this PR?

Introduce new ContextualizedObjectStore type that implements object_store::ObjectStore.

Are these changes tested?

I haven't written any tests for this behavior in datafusion yet and would like guidance from maintainers with respect to what kind of testing they think would be good here.

I also still need to manually test that this does the thing I want it to do with respect to tracing in a caching ObjectStore implementation in https://github.com/influxdata/influxdb

Are there any user-facing changes?

Only if the user registers a custom ObjectStore implementation with datafusion and wants to pass opaque data (like tracing spans) from various places in the call stack leading up to query execution -- after this they will have access to that data in their custom implementation of ObjectStore.get_opts when called during query execution.

@github-actions github-actions bot added core Core DataFusion crate execution Related to the execution crate labels Feb 21, 2025
Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Apr 24, 2025
@github-actions github-actions bot closed this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate execution Related to the execution crate Stale PR has not had any activity for some time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant