ScalarUDFImpl invoke improvements #13507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invoke is passed the return type created for the udf instance
github-actions
bot
added
logical-expr
alamb
commented
Nov 20, 2024
| // evaluate the function | ||
| let output = self.fun.invoke_batch(&inputs, batch.num_rows())?; | ||
| let output = self.fun.invoke_with_args(ScalarFunctionArgs { | ||
| args: inputs, |
There was a problem hiding this comment.
the whole point of this PR is to pass in inputs here rather than inputs.as_ref
There was a problem hiding this comment.
Eventually we should probably consider doing the same thing for evaluate 🤔
This was referenced Nov 21, 2024
|
Can we have one example function doing that, with some tests proving this indeed works? |
Just OCD following up here, there is an example / tests in this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #13290 from @joseph-isaacs
Which issue does this PR close?
ScalarUDFImpl::invoke_with_argsto support passing the return type created for the udf instance #13290Rationale for this change
If we are going to change the signature of
invokeI would to make it possible in the future to reuse allocations -- at the moment the API requires creating new arrays even when the input array is not used because the functions get the input as&[ColumnarValues]meaning they don't own them (the caller retains a reference)What changes are included in this PR?
Change ScalarFunctionArgs to pass by value
1,
Are these changes tested?
Are there any user-facing changes?