Add getters to ExecutionPlan Properties
#13409
Merged
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
linhr
approved these changes
Nov 14, 2024
alamb
approved these changes
Nov 14, 2024
alamb
changed the title
ExecutionPlan Properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
These were all of the
ExecutionPlanimplementations that I found that didn't expose all of their properties needed for instantiation. Exposing the properties now makes the API consistent across allExecutionPlanimplementations.What changes are included in this PR?
We exposed the properties of
NdJsonExec,SortMergeJoinExec,MemoryExec,RecursiveQueryExec,PartialSortExec, andWorkTableExec.Are these changes tested?
These are simple getters. No tests are needed.
Are there any user-facing changes?
These are backwards compatible changes to user-facing APIs.