Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: SortMergeJoin small refactoring #13398

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Minor: SortMergeJoin small refactoring #13398

merged 2 commits into from
Nov 13, 2024

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Rename structures to more meaningful names, adding more comments, remove unnecessary clones

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Nov 13, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @comphead -- this looks really nice to me 👨‍🍳 👌

@comphead
Copy link
Contributor Author

Something is broken :) On it

@comphead comphead merged commit e041b6a into apache:main Nov 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants