Annotate Expr::get_type()
with recursive
#13376
Merged
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #13310, closes #9375.
Rationale for this change
This is a small follow-up change to the previous PR to fix the stack overflow issue in #9375.
Please note that during the investigation 2 different issues were discovered:
debug
build due tosqlparser
, and this didn't come up withrelease
build: LargeOR
list overflows the stack #9375 (comment).release
build: LargeOR
list overflows the stack #9375 (comment).This PR fixes only the 2nd issue.
Most likely the 1st issue can also be fixed with stacker/recursive, but the change would be required in https://github.com/apache/datafusion-sqlparser-rs.
What changes are included in this PR?
This PR annotates
Expr::get_type
with#[recursive]
Are these changes tested?
Yes, with the
blowout2.zip
test provided in the issue description:Are there any user-facing changes?
No.