Skip to content

Introduce information_schema.parameters table #13341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Nov 10, 2024

Which issue does this PR close?

Part of #12144

Rationale for this change

Implement information_schema.parameters for the function arguments (input/output).

What changes are included in this PR?

Refer to Postgres, BigQuery, and MySQL, implement the following columns for the PARAMETERS table:

  • specific_catalog: Same as the session default catalog
  • specific_schema: Same as the session default schema
  • specific_name: the function name
  • ordinal_position: the 1-based position of the argument. (If it's an output parameter, it's always 1)
  • parameter_mode: It could be IN for the input argument or OUT for the output argument.
  • parameter_name: the argument name defined in the document.
  • data_type: the data type of the argument.
  • parameter_default: the default value of this argument. It's always null in DataFusion.
  • is_variadic: DataFusion custom field. If its TypeSignature is Variadic or VariadicAny, it's true.

Are these changes tested?

yes

Are there any user-facing changes?

A new table of information_schema.

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Nov 10, 2024
@goldmedal goldmedal marked this pull request as ready for review November 11, 2024 01:38
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@goldmedal goldmedal merged commit cb7ec85 into apache:main Nov 12, 2024
25 checks passed
@goldmedal
Copy link
Contributor Author

Thanks @jayzhan211 for reviewing

@goldmedal goldmedal deleted the feature/information-schema-parameters branch November 12, 2024 01:34
jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request Nov 12, 2024
alamb pushed a commit to alamb/datafusion that referenced this pull request Nov 13, 2024
wiedld added a commit to influxdata/arrow-datafusion that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants