draft: move ntile from logical expr to udf window #12884
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haile Lagi <[email protected]>
…-window-function-ntile-to-udf-window Signed-off-by: Haile Lagi <[email protected]>
* fix panic * Update datafusion/sql/src/select.rs Co-authored-by: Jonah Gao <[email protected]> * move issue --------- Co-authored-by: Jonah Gao <[email protected]>
…hema (apache#12876) * Update memory.rs * add assert * Update memory.rs * Update memory.rs * Update memory.rs * address review * Update memory.rs * Update memory.rs * final fix * Fix comments in test_utils.rs --------- Co-authored-by: Mehmet Ozan Kabak <[email protected]>
* add bench * Optimize iszero function (3-5x) faster
* Add macro for creating record batch, useful for unit test or rapid development * Update docstring * Add additional checks in unit test and rename macro per user input
…ter for Clickbench Q28) (apache#12792) * Implement special min/max accumulator for Strings: `MinMaxBytesAccumulator` * fix bug * fix msrv * move code, handle filters * simplify * Add functional tests * remove unecessary test * improve docs * improve docs * cleanup * improve comments * fix diagram * fix accounting * Use correct type in memory accounting * Add TODO comment
* Make PruningPredicate's rewrite public * feedback * Improve documentation and add default to ConstantUnhandledPredicatehook * Update pruning.rs --------- Co-authored-by: Andrew Lamb <[email protected]>
* Minor: add flags for temporary ddl Signed-off-by: Haile Lagi <[email protected]> * Update datafusion/proto/src/logical_plan/mod.rs Co-authored-by: Jonah Gao <[email protected]> --------- Signed-off-by: Haile Lagi <[email protected]> Co-authored-by: Jonah Gao <[email protected]>
* Documentation fixes + add * fmt fix * quick fix
* add bench * optimize signum
…he#12878) This is needed to implement the WindowUDF trait.
* unparse Sort with push down limit * cargo fmt * set query limit directly
* External aggregation metrics * clippy
* Move equivalence fuzz testing to fuzz test binary * fix license * fixup
* regex migrate * small fixes * update docs --------- Co-authored-by: Andrew Lamb <[email protected]>
github-actions
bot
added
documentation
hailelagi
deleted the
haile/convert-builtin-window-function-ntile-to-udf-window
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12694
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?