-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Migrate documentation for Aggregate Functions to code #12861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alamb @Omega359 I wasn't sure how to deal with the regr functions as their file is a little unique and I am not sure how to deal with them. We could possibly deal with them in another pr. Also might need to look deeper into some definitions and examples for some that didnt have old documentation yet (StringAgg, Grouping, NthValueAgg) |
Yes, let's handle them in a follow on PR
I'll try and make a PR for these -- it is great we have found a list of functions that were not previously documented Update: I see you already did this ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me -- thank you @jonathanc-n
I made a PR for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left a few suggestions for improvements
Since this was merged already if you want we can create a followup ticket for handling the suggestions. |
@Omega359 Yep sounds good, thanks for the review! |
Which issue does this PR close?
Closes #12827.
Rationale for this change
Migrate aggregate functions from static docs to new format.
What changes are included in this PR?
Migrated aggregate functions.
Are these changes tested?
Are there any user-facing changes?