Skip to content

Migrate documentation for Aggregate Functions to code #12861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

jonathanc-n
Copy link
Contributor

Which issue does this PR close?

Closes #12827.

Rationale for this change

Migrate aggregate functions from static docs to new format.

What changes are included in this PR?

Migrated aggregate functions.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added documentation Improvements or additions to documentation functions Changes to functions implementation labels Oct 11, 2024
@jonathanc-n
Copy link
Contributor Author

jonathanc-n commented Oct 11, 2024

@alamb @Omega359 I wasn't sure how to deal with the regr functions as their file is a little unique and I am not sure how to deal with them. We could possibly deal with them in another pr.

Also might need to look deeper into some definitions and examples for some that didnt have old documentation yet (StringAgg, Grouping, NthValueAgg)

@alamb alamb changed the title Aggregate Function Migration Migrate documentation for Aggregate Functions to code Oct 11, 2024
@alamb
Copy link
Contributor

alamb commented Oct 11, 2024

@alamb @Omega359 I wasn't sure how to deal with the regr functions as their file is a little unique and I am not sure how to deal with them. We could possibly deal with them in another pr.

Yes, let's handle them in a follow on PR

Also might need to look deeper into some definitions and examples for some that didnt have old documentation yet (StringAgg, Grouping, NthValueAgg)

I'll try and make a PR for these -- it is great we have found a list of functions that were not previously documented

Update: I see you already did this ❤️

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @jonathanc-n

@alamb
Copy link
Contributor

alamb commented Oct 11, 2024

I made a PR for the regr functions in #12871

@alamb alamb merged commit a8d3fae into apache:main Oct 11, 2024
26 checks passed
Copy link
Contributor

@Omega359 Omega359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left a few suggestions for improvements

@Omega359
Copy link
Contributor

Since this was merged already if you want we can create a followup ticket for handling the suggestions.

@jonathanc-n
Copy link
Contributor Author

@Omega359 Yep sounds good, thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation functions Changes to functions implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate documentation for aggregate functions from aggregate_functions.md to code
3 participants