Refactor `ByteGroupValueBuilder` to use `MaybeNullBufferBuilder` #12681

alamb · 2024-09-30T10:24:52Z

Which issue does this PR close?

Follow on to #12269 from @jayzhan211 and #12623
Part of #12680

Rationale for this change

#12623 added a more performant way to track nulls in the PrimitiveGroupValueBuilder. Let's use the same thing for Strings/Binary views to reduce replication

What changes are included in this PR?

Refactor ByteGroupValueBuilder to use MaybeNullBufferBuilder to track nulls

Are these changes tested?

Yes, by existing CI

Are there any user-facing changes?

No, this is an internal refactor

Performance (basically all changes within measurement threshold in my opinion)

--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query        ┃  main_base ┃ alamb_boolean_string_groups ┃       Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.19ms │                      2.47ms │ 1.12x slower │
│ QQuery 1     │    38.50ms │                     39.33ms │    no change │
│ QQuery 2     │    94.50ms │                     99.33ms │ 1.05x slower │
│ QQuery 3     │    99.87ms │                     99.86ms │    no change │
│ QQuery 4     │   932.23ms │                    931.81ms │    no change │
│ QQuery 5     │   970.52ms │                    989.52ms │    no change │
│ QQuery 6     │    37.22ms │                     36.55ms │    no change │
│ QQuery 7     │    42.96ms │                     42.71ms │    no change │
│ QQuery 8     │  1371.71ms │                   1354.54ms │    no change │
│ QQuery 9     │  1362.68ms │                   1360.57ms │    no change │
│ QQuery 10    │   342.18ms │                    344.68ms │    no change │
│ QQuery 11    │   395.77ms │                    395.40ms │    no change │
│ QQuery 12    │  1114.55ms │                   1086.39ms │    no change │
│ QQuery 13    │  1592.74ms │                   1714.17ms │ 1.08x slower │
│ QQuery 14    │  1242.36ms │                   1247.77ms │    no change │
│ QQuery 15    │  1087.20ms │                   1095.63ms │    no change │
│ QQuery 16    │  2570.55ms │                   2499.46ms │    no change │
│ QQuery 17    │  2351.69ms │                   2298.15ms │    no change │
│ QQuery 18    │  5035.87ms │                   4970.81ms │    no change │
│ QQuery 19    │    94.64ms │                     96.48ms │    no change │
│ QQuery 20    │  1744.71ms │                   1788.44ms │    no change │
│ QQuery 21    │  2006.06ms │                   2047.56ms │    no change │
│ QQuery 22    │  5202.56ms │                   5173.18ms │    no change │
│ QQuery 23    │ 10514.35ms │                  10580.71ms │    no change │
│ QQuery 24    │   600.74ms │                    609.46ms │    no change │
│ QQuery 25    │   493.64ms │                    516.33ms │    no change │
│ QQuery 26    │   666.07ms │                    666.23ms │    no change │
│ QQuery 27    │  2604.39ms │                   2585.89ms │    no change │
│ QQuery 28    │ 14826.24ms │                  14614.83ms │    no change │
│ QQuery 29    │   526.18ms │                    533.71ms │    no change │
│ QQuery 30    │  1044.06ms │                   1064.09ms │    no change │
│ QQuery 31    │  1137.63ms │                   1123.56ms │    no change │
│ QQuery 32    │  4267.90ms │                   4404.10ms │    no change │
│ QQuery 33    │  5117.07ms │                   5175.47ms │    no change │
│ QQuery 34    │  5179.28ms │                   5224.15ms │    no change │
│ QQuery 35    │  1907.07ms │                   1909.05ms │    no change │
│ QQuery 36    │   280.77ms │                    276.40ms │    no change │
│ QQuery 37    │   123.32ms │                    122.66ms │    no change │
│ QQuery 38    │   147.87ms │                    145.55ms │    no change │
│ QQuery 39    │   788.15ms │                    795.73ms │    no change │
│ QQuery 40    │    56.02ms │                     61.31ms │ 1.09x slower │
│ QQuery 41    │    47.95ms │                     50.08ms │    no change │
│ QQuery 42    │    62.18ms │                     66.27ms │ 1.07x slower │
└──────────────┴────────────┴─────────────────────────────┴──────────────┘

--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃ main_base ┃ alamb_boolean_string_groups ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │  190.34ms │                    189.37ms │     no change │
│ QQuery 2     │  123.05ms │                    120.34ms │     no change │
│ QQuery 3     │  129.96ms │                    121.71ms │ +1.07x faster │
│ QQuery 4     │   86.80ms │                     89.76ms │     no change │
│ QQuery 5     │  157.98ms │                    165.57ms │     no change │
│ QQuery 6     │   45.93ms │                     45.36ms │     no change │
│ QQuery 7     │  217.67ms │                    192.33ms │ +1.13x faster │
│ QQuery 8     │  176.63ms │                    148.94ms │ +1.19x faster │
│ QQuery 9     │  243.65ms │                    240.19ms │     no change │
│ QQuery 10    │  235.80ms │                    229.71ms │     no change │
│ QQuery 11    │   94.14ms │                     94.43ms │     no change │
│ QQuery 12    │  129.70ms │                    129.90ms │     no change │
│ QQuery 13    │  220.74ms │                    218.86ms │     no change │
│ QQuery 14    │   73.18ms │                     72.92ms │     no change │
│ QQuery 15    │  124.76ms │                    121.70ms │     no change │
│ QQuery 16    │   78.78ms │                     80.14ms │     no change │
│ QQuery 17    │  203.80ms │                    227.06ms │  1.11x slower │
│ QQuery 18    │  329.27ms │                    334.30ms │     no change │
│ QQuery 19    │  126.43ms │                    133.05ms │  1.05x slower │
│ QQuery 20    │  130.58ms │                    137.04ms │     no change │
│ QQuery 21    │  281.02ms │                    271.38ms │     no change │
│ QQuery 22    │   67.55ms │                     65.00ms │     no change │
└──────────────┴───────────┴─────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                          ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (main_base)                     │ 3467.77ms │
│ Total Time (alamb_boolean_string_groups)   │ 3429.05ms │
│ Average Time (main_base)                   │  157.63ms │
│ Average Time (alamb_boolean_string_groups) │  155.87ms │
│ Queries Faster                             │         3 │
│ Queries Slower                             │         2 │
│ Queries with No Change                     │        17 │
└────────────────────────────────────────────┴───────────┘

Dandandan · 2024-09-30T16:40:09Z

I left a comment here: 36a2003#r1781444375 , I think the code could be simplified a bit by using generics a bit more.

alamb · 2024-09-30T18:43:20Z

I left a comment here: 36a2003#r1781444375 , I think the code could be simplified a bit by using generics a bit more.

Thank you @Dandandan -- added to list on #12680

(note that link doesn't seem to work for me, but I found the relevant comment #12623 (comment))

alamb · 2024-10-01T14:53:17Z

This appears to have made another significant improvement in TPCH (presumably because the group keys aren't ever null)

Dandandan

👌

Dandandan · 2024-10-01T17:48:31Z

Really nice performance improvements 🚀

Dandandan · 2024-10-01T17:52:23Z

Hm actually looking at the performance change of TPCH sf 1,this doesn't seem correct to me (main seems out of date?).

alamb · 2024-10-01T18:51:58Z

Hm actually looking at the performance change of TPCH sf 1,this doesn't seem correct to me (main seems out of date?).

Yes, sorry -- I am rerunning the performance -- I think this is reporting based on main before @jayzhan211 's changes. Will update shortly

alamb · 2024-10-01T20:17:40Z

I re-ran benchmarks and posted them above -- TLDR is I don't think there are any significant differences in performance

alamb · 2024-10-01T20:19:07Z

I can potentially try the const NULLABLE thing too if we think that is worthwhile (I think it is likely that the special case for knowing about nullability is not super applicable to the real world -- aka anything other than TPCH)

jayzhan211

👍

alamb · 2024-10-02T10:31:41Z

Thank you for the reviews @jayzhan211 and @Dandandan

@etseidl

* Add support for external tables with qualified names (#12645) * Make support schemas * Set default name to table * Remove print statements and stale comment * Add tests for create table * Fix typo * Update datafusion/sql/src/statement.rs Co-authored-by: Jonah Gao <[email protected]> * convert create_external_table to objectname * Add sqllogic tests * Fix failing tests --------- Co-authored-by: Jonah Gao <[email protected]> * Fix Regex signature types (#12690) * Fix Regex signature types * Uncomment the shared tests in string_query.slt.part and removed tests copies everywhere else * Test `LIKE` and `MATCH` with flags; Remove new tests from regexp.slt * Refactor `ByteGroupValueBuilder` to use `MaybeNullBufferBuilder` (#12681) * Fix malformed hex string literal in docs (#12708) * Simplify match patterns in coercion rules (#12711) Remove conditions where unnecessary. Refactor to improve readability. * Remove aggregate functions dependency on frontend (#12715) * Remove aggregate functions dependency on frontend DataFusion is a SQL query engine and also a reusable library for building query engines. The core functionality should not depend on frontend related functionalities like `sqlparser` or `datafusion-sql`. * Remove duplicate license header * Minor: Remove clone in `transform_to_states` (#12707) * rm clone Signed-off-by: jayzhan211 <[email protected]> * fmt Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]> * Refactor tests for union sorting properties, add tests for unions and constants (#12702) * Refactor tests for union sorting properties * update doc test * Undo import reordering * remove unecessary static lifetimes * Fix: support Qualified Wildcard in count aggregate function (#12673) * Reduce code duplication in `PrimitiveGroupValueBuilder` with const generics (#12703) * Reduce code duplication in `PrimitiveGroupValueBuilder` with const generics * Fix docs * Disallow duplicated qualified field names (#12608) * Disallow duplicated qualified field names * Fix tests * Optimize base64/hex decoding by pre-allocating output buffers (~2x faster) (#12675) * add bench * replace macro with generic function * remove duplicated code * optimize base64/hex decode * Allow DynamicFileCatalog support to query partitioned file (#12683) * support to query partitioned table for dynamic file catalog * cargo clippy * split partitions inferring to another function * Support `LIMIT` Push-down logical plan optimization for `Extension` nodes (#12685) * Update trait `UserDefinedLogicalNodeCore` Signed-off-by: Austin Liu <[email protected]> * Update corresponding interface Signed-off-by: Austin Liu <[email protected]> Add rewrite rule for `push-down-limit` for `Extension` Signed-off-by: Austin Liu <[email protected]> * Add rewrite rule for `push-down-limit` for `Extension` and tests Signed-off-by: Austin Liu <[email protected]> * Update corresponding interface Signed-off-by: Austin Liu <[email protected]> * Reorganize to match guard Signed-off-by: Austin Liu <[email protected]> * Clena up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> --------- Signed-off-by: Austin Liu <[email protected]> * Fix AvroReader: Add union resolving for nested struct arrays (#12686) * Add union resolving for nested struct arrays * Add test * Change test * Reproduce index error * fmt --------- Co-authored-by: Andrew Lamb <[email protected]> * Adds macros for creating `WindowUDF` and `WindowFunction` expression (#12693) * Adds macro for udwf singleton * Adds a doc comment parameter to macro * Add doc comment for `create_udwf` macro * Uses default constructor * Update `Cargo.lock` in `datafusion-cli` * Fixes: expand `$FN_NAME` in doc strings * Adds example for macro usage * Renames macro * Improve doc comments * Rename udwf macro * Minor: doc copy edits * Adds macro for creating fluent-style expression API * Adds support for 1 or more parameters in expression function * Rewrite doc comments * Rename parameters * Minor: formatting * Adds doc comment for `create_udwf_expr` macro * Improve example docs * Hides extraneous code in doc comments * Add a one-line readme * Adds doc test assertions + minor formatting fixes * Adds common macro for defining user-defined window functions * Adds doc comment for `define_udwf_and_expr` * Defines `RowNumber` using common macro * Add usage example for common macro * Adds usage for custom constructor * Add examples for remaining patterns * Improve doc comments for usage examples * Rewrite inner line docs * Rewrite `create_udwf_expr!` doc comments * Minor doc improvements * Fix doc test and usage example * Add inline comments for macro patterns * Minor: change doc comment in example * Support unparsing plans with both Aggregation and Window functions (#12705) * Support unparsing plans with both Aggregation and Window functions (#35) * Fix unparsing for aggregation grouping sets * Add test for grouping set unparsing * Update datafusion/sql/src/unparser/utils.rs Co-authored-by: Jax Liu <[email protected]> * Update datafusion/sql/src/unparser/utils.rs Co-authored-by: Jax Liu <[email protected]> * Update * More tests --------- Co-authored-by: Jax Liu <[email protected]> * Fix strpos invocation with dictionary and null (#12712) In 1b3608d `strpos` signature was modified to indicate it supports dictionary as input argument, but the invoke method doesn't support them. * docs: Update DataFusion introduction to clarify that DataFusion does provide an "out of the box" query engine (#12666) * Update DataFusion introduction to show that DataFusion offers packaged versions for end users * change order * Update README.md Co-authored-by: Andrew Lamb <[email protected]> * refine wording and update user guide for consistency * prettier --------- Co-authored-by: Andrew Lamb <[email protected]> * Framework for generating function docs from embedded code documentation (#12668) * Initial work on #12432 to allow for generation of udf docs from embedded documentation in the code * Add missing license header. * Fixed examples. * Fixing a really weird RustRover/wsl ... something. No clue what happened there. * permission change * Cargo fmt update. * Refactored Documentation to allow it to be used in a const. * Add documentation for syntax_example * Refactoring Documentation based on PR feedback. * Cargo fmt update. * Doc update * Fixed copy/paste error. * Minor text updates. --------- Co-authored-by: Andrew Lamb <[email protected]> * Add IMDB(JOB) Benchmark [2/N] (imdb queries) (#12529) * imdb dataset * cargo fmt * Add 113 queries for IMDB(JOB) Signed-off-by: Austin Liu <[email protected]> * Add `get_query_sql` from `query_id` string Signed-off-by: Austin Liu <[email protected]> * Fix CSV reader & Remove Parquet partition Signed-off-by: Austin Liu <[email protected]> * Add benchmark IMDB runner Signed-off-by: Austin Liu <[email protected]> * Add `run_imdb` script Signed-off-by: Austin Liu <[email protected]> * Add checker for imdb option Signed-off-by: Austin Liu <[email protected]> * Add SLT for IMDB Signed-off-by: Austin Liu <[email protected]> * Fix `get_query_sql()` for CI roundtrip test Signed-off-by: Austin Liu <[email protected]> Fix `get_query_sql()` for CI roundtrip test Signed-off-by: Austin Liu <[email protected]> Fix `get_query_sql()` for CI roundtrip test Signed-off-by: Austin Liu <[email protected]> * Clean up Signed-off-by: Austin Liu <[email protected]> * Add missing license Signed-off-by: Austin Liu <[email protected]> * Add IMDB(JOB) queries `2b` to `5c` Signed-off-by: Austin Liu <[email protected]> * Add `INCLUDE_IMDB` in CI verify-benchmark-results Signed-off-by: Austin Liu <[email protected]> * Prepare IMDB dataset Signed-off-by: Austin Liu <[email protected]> Prepare IMDB dataset Signed-off-by: Austin Liu <[email protected]> * use uint as id type * format * Seperate `tpch` and `imdb` benchmarking CI jobs Signed-off-by: Austin Liu <[email protected]> Fix path Signed-off-by: Austin Liu <[email protected]> Fix path Signed-off-by: Austin Liu <[email protected]> Remove `tpch` in `imdb` benchmark Signed-off-by: Austin Liu <[email protected]> * Remove IMDB(JOB) slt in CI Signed-off-by: Austin Liu <[email protected]> Remove IMDB(JOB) slt in CI Signed-off-by: Austin Liu <[email protected]> --------- Signed-off-by: Austin Liu <[email protected]> Co-authored-by: DouPache <[email protected]> * Minor: avoid clone while calculating union equivalence properties (#12722) * Minor: avoid clone while calculating union equivalence properties * Update datafusion/physical-expr/src/equivalence/properties.rs * fmt * Simplify streaming_merge function parameters (#12719) * simplify streaming_merge function parameters * revert test change * change StreamingMergeConfig into builder pattern * Fix links on docs index page (#12750) * Provide field and schema metadata missing on cross joins, and union with null fields. (#12729) * test: reproducer for missing schema metadata on cross join * fix: pass thru schema metadata on cross join * fix: preserve metadata when transforming to view types * test: reproducer for missing field metadata in left hand NULL field of union * fix: preserve field metadata from right side of union * chore: safe indexing * Minor: Update string tests for strpos (#12739) * Apply `type_union_resolution` to array and values (#12753) * cleanup make array coercion rule Signed-off-by: jayzhan211 <[email protected]> * change to type union resolution Signed-off-by: jayzhan211 <[email protected]> * change value too Signed-off-by: jayzhan211 <[email protected]> * fix tpyo Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]> * Add `DocumentationBuilder::with_standard_argument` to reduce copy/paste (#12747) * Add `DocumentationBuilder::with_standard_expression` to reduce copy/paste * fix doc * fix standard argument * Update docs * Improve documentation to explain what is different * fix `equal_to` in `PrimitiveGroupValueBuilder` (#12758) * fix `equal_to` in `PrimitiveGroupValueBuilder`. * fix typo. * add uts. * reduce calling of `is_null`. * Minor: doc how field name is to be set (#12757) * Fix `equal_to` in `ByteGroupValueBuilder` (#12770) * Fix `equal_to` in `ByteGroupValueBuilder` * refactor null_equal_to * Update datafusion/physical-plan/src/aggregates/group_values/group_column.rs * Allow simplification even when nullable (#12746) The nullable requirement seem to have been added in #1401 but as far as I can tell they are not needed for these 2 cases. I think this can be shown using this truth table: (generated using datafusion-cli without this patch) ``` > CREATE TABLE t (v BOOLEAN) as values (true), (false), (NULL); > select t.v, t2.v, t.v AND (t.v OR t2.v), t.v OR (t.v AND t2.v) from t cross join t as t2; +-------+-------+---------------------+---------------------+ | v | v | t.v AND t.v OR t2.v | t.v OR t.v AND t2.v | +-------+-------+---------------------+---------------------+ | true | true | true | true | | true | false | true | true | | true | | true | true | | false | true | false | false | | false | false | false | false | | false | | false | false | | | true | | | | | false | | | | | | | | +-------+-------+---------------------+---------------------+ ``` And it seems Spark applies both of these and DuckDB applies only the first one. * Fix unnest conjunction with selecting wildcard expression (#12760) * fix unnest statement with wildcard expression * add commnets * Improve `round` scalar function unparsing for Postgres (#12744) * Postgres: enforce required `NUMERIC` type for `round` scalar function (#34) Includes initial support for dialects to override scalar functions unparsing * Document scalar_function_to_sql_overrides fn * Fix stack overflow calculating projected orderings (#12759) * Fix stack overflow calculating projected orderings * fix docs * Port / Add Documentation for `VarianceSample` and `VariancePopulation` (#12742) * Upgrade arrow/parquet to `53.1.0` / fix clippy (#12724) * Update to arrow/parquet 53.1.0 * Update some API * update for changed file sizes * Use non deprecated APIs * Use ParquetMetadataReader from @etseidl * remove upstreamed implementation * Update CSV schema * Use upstream is_null and is_not_null kernels * feat: add support for Substrait ExtendedExpression (#12728) * Add support for serializing and deserializing Substrait ExtendedExpr message * Address clippy reviews * Reuse existing rename method * Transformed::new_transformed: Fix documentation formatting (#12787) Co-authored-by: Andrew Lamb <[email protected]> * fix: Correct results for grouping sets when columns contain nulls (#12571) * Fix grouping sets behavior when data contains nulls * PR suggestion comment * Update new test case * Add grouping_id to the logical plan * Add doc comment next to INTERNAL_GROUPING_ID * Fix unparsing of Aggregate with grouping sets --------- Co-authored-by: Andrew Lamb <[email protected]> * Migrate documentation for all string functions from scalar_functions.md to code (#12775) * Added documentation for string and unicode functions. * Fixed issues with aliases. * Cargo fmt. * Minor doc fixes. * Update docs for var_pop/samp --------- Co-authored-by: Andrew Lamb <[email protected]> * Account for constant equivalence properties in union, tests (#12562) * Minor: clarify comment about empty dependencies (#12786) * Introduce Signature::String and return error if input of `strpos` is integer (#12751) * fix sig Signed-off-by: jayzhan211 <[email protected]> * fix Signed-off-by: jayzhan211 <[email protected]> * fix error Signed-off-by: jayzhan211 <[email protected]> * fix all signature Signed-off-by: jayzhan211 <[email protected]> * fix all signature Signed-off-by: jayzhan211 <[email protected]> * change default type Signed-off-by: jayzhan211 <[email protected]> * clippy Signed-off-by: jayzhan211 <[email protected]> * fix docs Signed-off-by: jayzhan211 <[email protected]> * rm deadcode Signed-off-by: jayzhan211 <[email protected]> * cleanup Signed-off-by: jayzhan211 <[email protected]> * cleanup Signed-off-by: jayzhan211 <[email protected]> * rm test Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]> * Minor: improve docs on MovingMin/MovingMax (#12790) * Add slt tests (#12721) --------- Signed-off-by: jayzhan211 <[email protected]> Signed-off-by: Austin Liu <[email protected]> Co-authored-by: OussamaSaoudi <[email protected]> Co-authored-by: Jonah Gao <[email protected]> Co-authored-by: Dmitrii Blaginin <[email protected]> Co-authored-by: Andrew Lamb <[email protected]> Co-authored-by: Tomoaki Kawada <[email protected]> Co-authored-by: Piotr Findeisen <[email protected]> Co-authored-by: Jay Zhan <[email protected]> Co-authored-by: HuSen <[email protected]> Co-authored-by: Emil Ejbyfeldt <[email protected]> Co-authored-by: Simon Vandel Sillesen <[email protected]> Co-authored-by: Jax Liu <[email protected]> Co-authored-by: Austin Liu <[email protected]> Co-authored-by: JonasDev1 <[email protected]> Co-authored-by: jcsherin <[email protected]> Co-authored-by: Sergei Grebnov <[email protected]> Co-authored-by: Andy Grove <[email protected]> Co-authored-by: Bruce Ritchie <[email protected]> Co-authored-by: DouPache <[email protected]> Co-authored-by: mertak-synnada <[email protected]> Co-authored-by: Bryce Mecum <[email protected]> Co-authored-by: wiedld <[email protected]> Co-authored-by: kamille <[email protected]> Co-authored-by: Weston Pace <[email protected]> Co-authored-by: Val Lorentz <[email protected]>

github-actions bot added the physical-expr Physical Expressions label Sep 30, 2024

alamb marked this pull request as draft September 30, 2024 10:25

alamb mentioned this pull request Sep 30, 2024

[EPIC] Improvements to GroupColumn multi-column aggregation performance #12680

Open

14 tasks

Refactor ByteGroupValueBuilder to use MaybeNullBufferBuilder

c06d0ba

alamb force-pushed the alamb/boolean_string_groups branch from 139a326 to c06d0ba Compare September 30, 2024 14:59

alamb marked this pull request as ready for review October 1, 2024 14:52

alamb requested a review from jayzhan211 October 1, 2024 14:53

Dandandan approved these changes Oct 1, 2024

View reviewed changes

jayzhan211 approved these changes Oct 2, 2024

View reviewed changes

alamb merged commit ed0949e into apache:main Oct 2, 2024
28 checks passed

alamb deleted the alamb/boolean_string_groups branch October 2, 2024 10:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor `ByteGroupValueBuilder` to use `MaybeNullBufferBuilder` #12681

Refactor `ByteGroupValueBuilder` to use `MaybeNullBufferBuilder` #12681

alamb commented Sep 30, 2024 •

edited

Loading

Dandandan commented Sep 30, 2024 •

edited

Loading

alamb commented Sep 30, 2024

alamb commented Oct 1, 2024

Dandandan left a comment

Dandandan commented Oct 1, 2024

Dandandan commented Oct 1, 2024 •

edited

Loading

alamb commented Oct 1, 2024

alamb commented Oct 1, 2024

alamb commented Oct 1, 2024 •

edited

Loading

jayzhan211 left a comment

alamb commented Oct 2, 2024

Refactor ByteGroupValueBuilder to use MaybeNullBufferBuilder #12681

Refactor ByteGroupValueBuilder to use MaybeNullBufferBuilder #12681

Conversation

alamb commented Sep 30, 2024 • edited Loading

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Dandandan commented Sep 30, 2024 • edited Loading

alamb commented Sep 30, 2024

alamb commented Oct 1, 2024

Dandandan left a comment

Choose a reason for hiding this comment

Dandandan commented Oct 1, 2024

Dandandan commented Oct 1, 2024 • edited Loading

alamb commented Oct 1, 2024

alamb commented Oct 1, 2024

alamb commented Oct 1, 2024 • edited Loading

jayzhan211 left a comment

Choose a reason for hiding this comment

alamb commented Oct 2, 2024

Refactor `ByteGroupValueBuilder` to use `MaybeNullBufferBuilder` #12681

Refactor `ByteGroupValueBuilder` to use `MaybeNullBufferBuilder` #12681

alamb commented Sep 30, 2024 •

edited

Loading

Dandandan commented Sep 30, 2024 •

edited

Loading

Dandandan commented Oct 1, 2024 •

edited

Loading

alamb commented Oct 1, 2024 •

edited

Loading