Fill in missing Debug fields for SessionState
#12663
Merged
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… informs this is unnecessary This reverts commit f69d73c.
… keep consistent Debug field order with `SessionState`
… `CatalogProviderList` requires `Debug`
…Builder` now that the fields all require `Debug`
…Builder` now that the fields have `Debug` available
…usion into catalog_provider_list
Catalog provider list
alamb
reviewed
Sep 28, 2024
| @@ -174,27 +174,30 @@ pub struct SessionState { | |||
| } | |||
|
|
|||
| impl Debug for SessionState { | |||
| /// Prefer having short fields at the top and long vector fields near the end | |||
| /// Group fields by | |||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | |||
There was a problem hiding this comment.
Can we perhaps use #derive(Debug) instead?
There was a problem hiding this comment.
let's do it as a follow on. This PR is better than what is on main I think
alamb
approved these changes
Sep 29, 2024
|
Thanks again @AnthonyZhOon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Uses #12555 to improve the
Debugimpl ofSessionStateRationale for this change
Now that the
DebugforSessionStateBuildercovers all fields, this change, all fields ofSessionStatecan also be shown in debugs.What changes are included in this PR?
SessionStateAre these changes tested?
By CI and the compiler
Are there any user-facing changes?
A different result from debug printing
SessionStatewhere the previously missing fields are now visible.