Minor: Improve documentation on execution error handling #12651
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
github-actions
bot
added
physical-expr
alamb
changed the title
alamb
changed the title
andygrove
reviewed
Sep 27, 2024
alamb
changed the title
Co-authored-by: Andy Grove <[email protected]>
github-actions
bot
removed
the
documentation
comphead
reviewed
Sep 28, 2024
comphead
approved these changes
Sep 28, 2024
Co-authored-by: Oleks V <[email protected]>
|
Thanks @comphead and @andygrove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #12641 and #12642
Rationale for this change
#12642 proposes changing the current behavior on error. While reviewing that code I realized the current behavior is not well documented.
What changes are included in this PR?
Document the error handling behavior better
Are these changes tested?
N/A
Are there any user-facing changes?
Just documentation, no functional changes