Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: add partial assertion for skip aggregation probe #12640

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Minor: add partial assertion for skip aggregation probe #12640

merged 6 commits into from
Sep 30, 2024
+55 −8

Commits on Sep 27, 2024

  1. add partial assertion for skip aggr probe and improve comments.

    @Rachelint
    Rachelint committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4c86c61 View commit details
    Browse the repository at this point in the history

  2. fix fmt.

    @Rachelint
    Rachelint committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0b01026 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. use pattern match for aggr mode to improve readability.

    @Rachelint
    Rachelint committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    60abcee View commit details
    Browse the repository at this point in the history

  2. only check should_skip_aggregation in partial aggr.

    @Rachelint
    Rachelint committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    8941b16 View commit details
    Browse the repository at this point in the history

  3. make some condition check assert check.

    @Rachelint
    Rachelint committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7db0703 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. clearer way to distinguish partial and terminals branches.

    @Rachelint
    Rachelint committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    b29d993 View commit details
    Browse the repository at this point in the history