Skip to content

Remove AggregateExpr trait #12096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 27, 2024
Merged

Remove AggregateExpr trait #12096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0372f41
save
lewiszlw Aug 20, 2024
a890912
Merge main
lewiszlw Aug 21, 2024
7a7c783
Move AggregateFunctionExpr into physical-expr crate
lewiszlw Aug 21, 2024
4b86152
Move AggregateExpr trait into physical-expr crate
lewiszlw Aug 21, 2024
03f3ec8
Remove AggregateExpr trait
lewiszlw Aug 21, 2024
2158789
Fix doc and tests
lewiszlw Aug 21, 2024
8461a51
Remove empty crate physical-expr-functions-aggregate
lewiszlw Aug 21, 2024
a918e7e
Use func name instead of expr name
lewiszlw Aug 21, 2024
5a553da
Fix tests
lewiszlw Aug 21, 2024
f9d7d4c
Merge branch 'main' into remove-aggr-expr-trait
lewiszlw Aug 22, 2024
cb83a8b
Fix tests and clippy lints
lewiszlw Aug 22, 2024
07ff35f
Cargo update for datafusion-cli
lewiszlw Aug 22, 2024
aeaf520
Add docs
lewiszlw Aug 22, 2024
3320d07
Merge main
lewiszlw Aug 22, 2024
a5a9570
Add functions back
lewiszlw Aug 22, 2024
70ea79c
Fix doc
lewiszlw Aug 22, 2024
0ae91d2
Merge main
lewiszlw Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ members = [
"datafusion/optimizer",
"datafusion/physical-expr",
"datafusion/physical-expr-common",
"datafusion/physical-expr-functions-aggregate",
"datafusion/physical-optimizer",
"datafusion/physical-plan",
"datafusion/proto",
Expand Down Expand Up @@ -106,7 +105,6 @@ datafusion-functions-window = { path = "datafusion/functions-window", version =
datafusion-optimizer = { path = "datafusion/optimizer", version = "41.0.0", default-features = false }
datafusion-physical-expr = { path = "datafusion/physical-expr", version = "41.0.0", default-features = false }
datafusion-physical-expr-common = { path = "datafusion/physical-expr-common", version = "41.0.0", default-features = false }
datafusion-physical-expr-functions-aggregate = { path = "datafusion/physical-expr-functions-aggregate", version = "41.0.0" }
datafusion-physical-optimizer = { path = "datafusion/physical-optimizer", version = "41.0.0" }
datafusion-physical-plan = { path = "datafusion/physical-plan", version = "41.0.0" }
datafusion-proto = { path = "datafusion/proto", version = "41.0.0" }
Expand Down
Loading
Loading