Minor: move batch spilling methods to lib.rs to make it reusable
#11154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Jun 28, 2024
| @@ -29,10 +29,10 @@ use crate::aggregates::{ | |||
| }; | |||
| use crate::common::IPCWriter; | |||
| use crate::metrics::{BaselineMetrics, RecordOutput}; | |||
| use crate::sorts::sort::{read_spill_as_stream, sort_batch}; | |||
| use crate::sorts::sort::sort_batch; | |||
There was a problem hiding this comment.
Maybe we can do the same with sort_batch
There was a problem hiding this comment.
Thanks @alamb I'll probably leave it as is, as it tied to sorting logic. Once we have another use case for making it a helper method and move it the same way for sure.
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #9359 .
Rationale for this change
It looks like a bunch of useful spilling batch methods that can be used in any place whenever spilling is needed, not only for the sorting
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?