Minor: Simplify conjunction and disjunction, improve docs #10446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 10, 2024
| @@ -1107,20 +1107,49 @@ fn split_binary_impl<'a>( | |||
| /// assert_eq!(conjunction(split), Some(expr)); | |||
| /// ``` | |||
| pub fn conjunction(filters: impl IntoIterator<Item = Expr>) -> Option<Expr> { | |||
| filters.into_iter().reduce(|accum, expr| accum.and(expr)) | |||
| filters.into_iter().reduce(Expr::and) | |||
There was a problem hiding this comment.
this is the very minor simplification and while I was in here I figured I would improve the docs too
alamb
force-pushed
the
alamb/simplify_conjucntion
branch
from
c873b4f to
9bc4fbf
Compare
jayzhan211
reviewed
May 13, 2024
| pub fn disjunction(filters: impl IntoIterator<Item = Expr>) -> Option<Expr> { | ||
| filters.into_iter().reduce(|accum, expr| accum.or(expr)) | ||
| filters.into_iter().reduce(Expr::or) |
There was a problem hiding this comment.
Wow, surprise that this works
There was a problem hiding this comment.
Yeah, that was my first reaction when I saw this in Filter pushdown and it took me a while to figure out what was actually doing 🤯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
I ran into this code while working on #10291
What changes are included in this PR?
conjunctionanddisjunctionAre these changes tested?
New doc test and existing CI
Are there any user-facing changes?